mirror of
https://github.com/nushell/nushell.git
synced 2024-11-28 11:24:09 +01:00
399a7c8836
# Description This PR introduces a new `Signals` struct to replace our adhoc passing around of `ctrlc: Option<Arc<AtomicBool>>`. Doing so has a few benefits: - We can better enforce when/where resetting or triggering an interrupt is allowed. - Consolidates `nu_utils::ctrl_c::was_pressed` and other ad-hoc re-implementations into a single place: `Signals::check`. - This allows us to add other types of signals later if we want. E.g., exiting or suspension. - Similarly, we can more easily change the underlying implementation if we need to in the future. - Places that used to have a `ctrlc` of `None` now use `Signals::empty()`, so we can double check these usages for correctness in the future. |
||
---|---|---|
.. | ||
diff.rs | ||
fake_persistent_plugin.rs | ||
fake_register.rs | ||
lib.rs | ||
plugin_test.rs | ||
spawn_fake_plugin.rs |