mirror of
https://github.com/nushell/nushell.git
synced 2024-11-30 04:14:17 +01:00
af82eeca72
# Description This PR removes `record` processing from the `length` command. It just doesn't make sense to try and get the length of a record. This PR also removes the `--column` parameter. If you want to list or count columns, you could use `$table | columns` or `$table | columns | length`. close #10074 ### Before  ### After Catches records two different ways now. with the `input_output_types` checker  and with additional logic in the command for cases like `echo`  # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
92 lines
2.3 KiB
Rust
92 lines
2.3 KiB
Rust
use nu_test_support::fs::Stub::EmptyFile;
|
|
use nu_test_support::nu;
|
|
use nu_test_support::playground::Playground;
|
|
|
|
#[test]
|
|
fn gets_first_rows_by_amount() {
|
|
Playground::setup("first_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![
|
|
EmptyFile("los.txt"),
|
|
EmptyFile("tres.txt"),
|
|
EmptyFile("amigos.txt"),
|
|
EmptyFile("arepas.clu"),
|
|
]);
|
|
|
|
let actual = nu!(cwd: dirs.test(), "ls | first 3 | length");
|
|
|
|
assert_eq!(actual.out, "3");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn gets_all_rows_if_amount_higher_than_all_rows() {
|
|
Playground::setup("first_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![
|
|
EmptyFile("los.txt"),
|
|
EmptyFile("tres.txt"),
|
|
EmptyFile("amigos.txt"),
|
|
EmptyFile("arepas.clu"),
|
|
]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), "ls | first 99 | length");
|
|
|
|
assert_eq!(actual.out, "4");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn gets_first_row_when_no_amount_given() {
|
|
Playground::setup("first_test_3", |dirs, sandbox| {
|
|
sandbox.with_files(vec![EmptyFile("caballeros.txt"), EmptyFile("arepas.clu")]);
|
|
|
|
// FIXME: We should probably change first to return a one row table instead of a record here
|
|
let actual = nu!(cwd: dirs.test(), "ls | first | values | length");
|
|
|
|
assert_eq!(actual.out, "4");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn gets_first_row_as_list_when_amount_given() {
|
|
let actual = nu!("[1, 2, 3] | first 1 | describe");
|
|
|
|
assert_eq!(actual.out, "list<int> (stream)");
|
|
}
|
|
|
|
#[test]
|
|
fn gets_first_bytes() {
|
|
let actual = nu!("(0x[aa bb cc] | first 2) == 0x[aa bb]");
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn gets_first_byte() {
|
|
let actual = nu!("0x[aa bb cc] | first");
|
|
|
|
assert_eq!(actual.out, "170");
|
|
}
|
|
|
|
#[test]
|
|
// covers a situation where `first` used to behave strangely on list<binary> input
|
|
fn works_with_binary_list() {
|
|
let actual = nu!("([0x[01 11]] | first) == 0x[01 11]");
|
|
|
|
assert_eq!(actual.out, "true");
|
|
}
|
|
|
|
#[test]
|
|
fn errors_on_negative_rows() {
|
|
let actual = nu!("[1, 2, 3] | first -10");
|
|
|
|
assert!(actual.err.contains("use a positive value"));
|
|
}
|
|
|
|
#[test]
|
|
fn errors_on_empty_list_when_no_rows_given() {
|
|
let actual = nu!("[] | first");
|
|
|
|
assert!(actual.err.contains("index too large"));
|
|
}
|