mirror of
https://github.com/nushell/nushell.git
synced 2024-11-29 03:44:19 +01:00
63335e99ae
closes #12115 # Description This fix addresses a bug where the --tabs flag couldn't be utilized due to improper handling of the tab quantity provided by the user. Previously, the code mistakenly attempted to convert the tab quantity to a boolean value, leading to a conversion error. The resolution involves adjusting the condition clauses to properly validate the presence of the flag's value. Now, the code checks whether the get_flag() function returns a value or None associated with the --tabs flag. This adjustment enables the --tabs flag to function correctly, triggering the appropriate condition and allowing the conversion to proceed as expected. Similarly, the fix applies to the --indent flag. Additionally, a default case was added, and the conversion now works properly without flags. Two tests were added to validate the corrected behavior of these flags. # User-Facing Changes Now the conversion should work properly instead of displaying an error. # Tests + Formatting -🟢 toolkit fmt -🟢 toolkit clippy -🟢 toolkit test -🟢 toolkit test stdlib To run added tests: - cargo test --package nu-command --test main -- format_conversions::json::test_tabs_indent_flag - cargo test --package nu-command --test main -- format_conversions::json::test_indent_flag |
||
|---|---|---|
| .. | ||
| csv.rs | ||
| html.rs | ||
| json.rs | ||
| markdown.rs | ||
| mod.rs | ||
| nuon.rs | ||
| ods.rs | ||
| ssv.rs | ||
| toml.rs | ||
| tsv.rs | ||
| url.rs | ||
| xlsx.rs | ||
| xml.rs | ||
| yaml.rs | ||