From 65849c95e28299eb7165e746e0504c42f2e3cb8c Mon Sep 17 00:00:00 2001 From: Bas Zoetekouw Date: Thu, 21 Mar 2024 16:43:37 +0100 Subject: [PATCH] add comment about per-network aliases Signed-off-by: Bas Zoetekouw --- podman_compose.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/podman_compose.py b/podman_compose.py index 29cc86f..9abaaa1 100755 --- a/podman_compose.py +++ b/podman_compose.py @@ -853,8 +853,12 @@ def get_net_args(compose, cnt): net_names.append(net_name) net_names_str = ",".join(net_names) - # TODO add support for per-interface aliases - # see https://docs.docker.com/compose/compose-file/compose-file-v3/#aliases + # TODO: add support for per-interface aliases + # See https://docs.docker.com/compose/compose-file/compose-file-v3/#aliases + # Even though podman accepts network-specific aliases (e.g., --network=bridge:alias=foo, + # podman currently ignores this if a per-container network-alias is set; as pdoman-compose + # always sets a network-alias to the container name, is currently doesn't make sense to + # implement this. multiple_nets = cnt.get("networks", None) if multiple_nets and len(multiple_nets) > 1: # networks can be specified as a dict with config per network or as a plain list without