From f2db75cea99e8376457c610da06a0a583503e595 Mon Sep 17 00:00:00 2001 From: Matthew Leonberger Date: Sun, 24 Sep 2017 20:43:41 +0900 Subject: [PATCH] Use run instead of popen so that things are closed correctly Use run instead of popen so that things are closed correctly --- pywal/colors.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pywal/colors.py b/pywal/colors.py index 9984b6e..4ed4b4b 100644 --- a/pywal/colors.py +++ b/pywal/colors.py @@ -18,12 +18,12 @@ def imagemagick(color_count, img): else: magick_command = ["convert"] - colors = subprocess.Popen([*magick_command, img, "-resize", "25%", - "+dither", "-colors", str(color_count), - "-unique-colors", "txt:-"], - stdout=subprocess.PIPE) + colors = subprocess.run([*magick_command, img, "-resize", "25%", + "+dither", "-colors", str(color_count), + "-unique-colors", "txt:-"], + stdout=subprocess.PIPE) - return colors.stdout.readlines() + return colors.stdout.splitlines() def gen_colors(img, color_count):