From 0010090d0517976248894bbd48a9bb1ac5bc0182 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Wed, 26 Feb 2025 12:21:35 +0000 Subject: [PATCH] vfs: fix integration test failures In this commit ceef78ce4493f8d0 vfs: fix directory cache serving stale data We added a new test which caused lots of integration test failures. This fixes the problem by disabling the test unless the feature flag DirModTimeUpdatesOnWrite is present on the remote. --- vfs/dir_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/vfs/dir_test.go b/vfs/dir_test.go index 69e45c269..5a4b63e04 100644 --- a/vfs/dir_test.go +++ b/vfs/dir_test.go @@ -658,10 +658,14 @@ func TestDirFileOpen(t *testing.T) { } func TestDirEntryModTimeInvalidation(t *testing.T) { - if runtime.GOOS == "windows" { + r, vfs := newTestVFS(t) + features := r.Fremote.Features() + if !features.DirModTimeUpdatesOnWrite { + t.Skip("Need DirModTimeUpdatesOnWrite") + } + if features.IsLocal && runtime.GOOS == "windows" { t.Skip("dirent modtime is unreliable on Windows filesystems") } - r, vfs := newTestVFS(t) // Needs to be less than 2x the wait time below, othewrwise the entry // gets cleared out before it had a chance to be updated.