extern/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-02-10 07:31:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

vfs,local: Log an ERROR if we fail to set the file to be sparse

Browse Source 
See: https://forum.rclone.org/t/rclone-1-53-release/18880/73
This commit is contained in:
Nick Craig-Wood 2020-09-11 15:34:58 +01:00
parent 937dd7fa1f
commit 0f895c0697
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
backend/local/local.go
View File

@ -1213,7 +1213,7 @@ func (f *Fs) OpenWriterAt(ctx context.Context, remote string, size int64) (fs.Wr
// Set the file to be a sparse file (important on Windows) // Set the file to be a sparse file (important on Windows)
err = file.SetSparse(out) err = file.SetSparse(out)
if err != nil { if err != nil {
fs.Debugf(o, "Failed to set sparse: %v", err) fs.Errorf(o, "Failed to set sparse: %v", err)
} }
} }

5
vfs/help.go
View File

@ -166,6 +166,11 @@ whereas the --vfs-read-ahead is buffered on disk.
When using this mode it is recommended that --buffer-size is not set When using this mode it is recommended that --buffer-size is not set
too big and --vfs-read-ahead is set large if required. too big and --vfs-read-ahead is set large if required.
**IMPORTANT** not all file systems support sparse files. In particular
FAT/exFAT do not. Rclone will perform very badly if the cache
directory is on a filesystem which doesn't support sparse files and it
will log an ERROR message if one is detected.
### VFS Performance ### VFS Performance
These flags may be used to enable/disable features of the VFS for These flags may be used to enable/disable features of the VFS for

4
vfs/vfscache/item.go
View File

@ -249,7 +249,7 @@ func (item *Item) _truncate(size int64) (err error) {
err = file.SetSparse(fd) err = file.SetSparse(fd)
if err != nil { if err != nil {
fs.Debugf(item.name, "vfs cache: truncate: failed to set as a sparse file: %v", err) fs.Errorf(item.name, "vfs cache: truncate: failed to set as a sparse file: %v", err)
} }
} }
@ -446,7 +446,7 @@ func (item *Item) _createFile(osPath string) (err error) {
} }
err = file.SetSparse(fd) err = file.SetSparse(fd)
if err != nil { if err != nil {
fs.Debugf(item.name, "vfs cache: failed to set as a sparse file: %v", err) fs.Errorf(item.name, "vfs cache: failed to set as a sparse file: %v", err)
} }
item.fd = fd item.fd = fd