From 330c6702ebfa35d01f8a56da0094928f941f70aa Mon Sep 17 00:00:00 2001 From: albertony <12441419+albertony@users.noreply.github.com> Date: Sat, 1 Jun 2024 11:43:49 +0200 Subject: [PATCH] build: ignore remaining gocritic lint issues --- backend/b2/api/types_test.go | 6 +++--- backend/s3/s3.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/backend/b2/api/types_test.go b/backend/b2/api/types_test.go index 6074de017..f350745fc 100644 --- a/backend/b2/api/types_test.go +++ b/backend/b2/api/types_test.go @@ -42,11 +42,11 @@ func TestTimestampIsZero(t *testing.T) { } func TestTimestampEqual(t *testing.T) { - assert.False(t, emptyT.Equal(emptyT)) + assert.False(t, emptyT.Equal(emptyT)) //nolint:gocritic // Don't include gocritic when running golangci-lint to avoid dupArg: suspicious method call with the same argument and receiver assert.False(t, t0.Equal(emptyT)) assert.False(t, emptyT.Equal(t0)) assert.False(t, t0.Equal(t1)) assert.False(t, t1.Equal(t0)) - assert.True(t, t0.Equal(t0)) - assert.True(t, t1.Equal(t1)) + assert.True(t, t0.Equal(t0)) //nolint:gocritic // Don't include gocritic when running golangci-lint to avoid dupArg: suspicious method call with the same argument and receiver + assert.True(t, t1.Equal(t1)) //nolint:gocritic // Don't include gocritic when running golangci-lint to avoid dupArg: suspicious method call with the same argument and receiver } diff --git a/backend/s3/s3.go b/backend/s3/s3.go index fbc3327a0..8278d4d08 100644 --- a/backend/s3/s3.go +++ b/backend/s3/s3.go @@ -3392,7 +3392,7 @@ func setQuirks(opt *Options) { // See: https://issuetracker.google.com/issues/323465186 // So make cutoff very large which it does seem to support opt.CopyCutoff = math.MaxInt64 - default: + default: //nolint:gocritic // Don't include gocritic when running golangci-lint to avoid defaultCaseOrder: consider to make `default` case as first or as last case fs.Logf("s3", "s3 provider %q not known - please set correctly", opt.Provider) fallthrough case "Other":