extern/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-07-01 04:50:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

vfs: make sure write only handles never truncate files they shouldn't

Browse Source
This commit is contained in:
Nick Craig-Wood
2017-11-20 18:01:42 +00:00
parent 76b151984c
commit 3fb4fe31d2
5 changed files with 94 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
vfs/file.go
View File

@ -260,13 +260,13 @@ func (f *File) OpenRead() (fh *ReadFileHandle, err error) {
}
// OpenWrite open the file for write
func (f *File) OpenWrite() (fh *WriteFileHandle, err error) {
func (f *File) OpenWrite(flags int) (fh *WriteFileHandle, err error) {
if f.d.vfs.Opt.ReadOnly {
return nil, EROFS
}
// fs.Debugf(o, "File.OpenWrite")
fh, err = newWriteFileHandle(f.d, f, f.Path())
fh, err = newWriteFileHandle(f.d, f, f.Path(), flags)
if err != nil {
err = errors.Wrap(err, "open for write")
fs.Errorf(f, "File.OpenWrite failed: %v", err)
@ -393,13 +393,13 @@ func (f *File) Open(flags int) (fd Handle, err error) {
// Open write only and hope the user doesn't
// want to read. If they do they will get an
// EPERM plus an Error log.
fd, err = f.OpenWrite()
fd, err = f.OpenWrite(flags)
}
} else if write {
if CacheMode >= CacheModeWrites {
fd, err = f.OpenRW(flags)
} else {
fd, err = f.OpenWrite()
fd, err = f.OpenWrite(flags)
}
} else if read {
if CacheMode >= CacheModeFull {