extern/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2024-11-24 17:34:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

build: fix gocritic lint issue unslice

Browse Source
This commit is contained in:
albertony 2024-05-31 14:33:10 +02:00 committed by Nick Craig-Wood
parent afd199d756
commit 59501fcdb6
4 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
backend/azureblob/azureblob.go
View File

@ -2094,7 +2094,6 @@ func (w *azChunkWriter) WriteChunk(ctx context.Context, chunkNumber int, reader
return 0, nil return 0, nil
} }
md5sum := m.Sum(nil) md5sum := m.Sum(nil)
transactionalMD5 := md5sum[:]
// increment the blockID and save the blocks for finalize // increment the blockID and save the blocks for finalize
var binaryBlockID [8]byte // block counter as LSB first 8 bytes var binaryBlockID [8]byte // block counter as LSB first 8 bytes
@ -2117,7 +2116,7 @@ func (w *azChunkWriter) WriteChunk(ctx context.Context, chunkNumber int, reader
} }
options := blockblob.StageBlockOptions{ options := blockblob.StageBlockOptions{
// Specify the transactional md5 for the body, to be validated by the service. // Specify the transactional md5 for the body, to be validated by the service.
TransactionalValidation: blob.TransferValidationTypeMD5(transactionalMD5), TransactionalValidation: blob.TransferValidationTypeMD5(md5sum),
} }
_, err = w.ui.blb.StageBlock(ctx, blockID, &readSeekCloser{Reader: reader, Seeker: reader}, &options) _, err = w.ui.blb.StageBlock(ctx, blockID, &readSeekCloser{Reader: reader, Seeker: reader}, &options)
if err != nil { if err != nil {

4
backend/oracleobjectstorage/multipart.go
View File

@ -148,7 +148,7 @@ func (w *objectChunkWriter) WriteChunk(ctx context.Context, chunkNumber int, rea
} }
md5sumBinary := m.Sum([]byte{}) md5sumBinary := m.Sum([]byte{})
w.addMd5(&md5sumBinary, int64(chunkNumber)) w.addMd5(&md5sumBinary, int64(chunkNumber))
md5sum := base64.StdEncoding.EncodeToString(md5sumBinary[:]) md5sum := base64.StdEncoding.EncodeToString(md5sumBinary)
// Object storage requires 1 <= PartNumber <= 10000 // Object storage requires 1 <= PartNumber <= 10000
ossPartNumber := chunkNumber + 1 ossPartNumber := chunkNumber + 1
@ -279,7 +279,7 @@ func (w *objectChunkWriter) addMd5(md5binary *[]byte, chunkNumber int64) {
if extend := end - int64(len(w.md5s)); extend > 0 { if extend := end - int64(len(w.md5s)); extend > 0 {
w.md5s = append(w.md5s, make([]byte, extend)...) w.md5s = append(w.md5s, make([]byte, extend)...)
} }
copy(w.md5s[start:end], (*md5binary)[:]) copy(w.md5s[start:end], (*md5binary))
} }
func (o *Object) prepareUpload(ctx context.Context, src fs.ObjectInfo, options []fs.OpenOption) (ui uploadInfo, err error) { func (o *Object) prepareUpload(ctx context.Context, src fs.ObjectInfo, options []fs.OpenOption) (ui uploadInfo, err error) {

4
backend/s3/s3.go
View File

@ -5964,7 +5964,7 @@ func (w *s3ChunkWriter) addMd5(md5binary *[]byte, chunkNumber int64) {
if extend := end - int64(len(w.md5s)); extend > 0 { if extend := end - int64(len(w.md5s)); extend > 0 {
w.md5s = append(w.md5s, make([]byte, extend)...) w.md5s = append(w.md5s, make([]byte, extend)...)
} }
copy(w.md5s[start:end], (*md5binary)[:]) copy(w.md5s[start:end], (*md5binary))
} }
// WriteChunk will write chunk number with reader bytes, where chunk number >= 0 // WriteChunk will write chunk number with reader bytes, where chunk number >= 0
@ -5994,7 +5994,7 @@ func (w *s3ChunkWriter) WriteChunk(ctx context.Context, chunkNumber int, reader
} }
md5sumBinary := m.Sum([]byte{}) md5sumBinary := m.Sum([]byte{})
w.addMd5(&md5sumBinary, int64(chunkNumber)) w.addMd5(&md5sumBinary, int64(chunkNumber))
md5sum := base64.StdEncoding.EncodeToString(md5sumBinary[:]) md5sum := base64.StdEncoding.EncodeToString(md5sumBinary)
// S3 requires 1 <= PartNumber <= 10000 // S3 requires 1 <= PartNumber <= 10000
s3PartNumber := aws.Int32(int32(chunkNumber + 1)) s3PartNumber := aws.Int32(int32(chunkNumber + 1))

2
lib/buildinfo/osversion_windows.go
View File

@ -93,5 +93,5 @@ func getRegistryVersionString(name string) string {
return "" return ""
} }
return windows.UTF16ToString(regBuf[:]) return windows.UTF16ToString(regBuf)
} }