From 8a51e11d23810de1de838394196be29e8f6ea26c Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Thu, 10 Jul 2025 10:44:41 +0100 Subject: [PATCH] imagekit: don't low level retry uploads Low level retrying uploads can lead to partial or empty files being uploaded as the io.Reader has been read in the first attempt. --- backend/imagekit/imagekit.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/imagekit/imagekit.go b/backend/imagekit/imagekit.go index 82dac3cbd..78be43e36 100644 --- a/backend/imagekit/imagekit.go +++ b/backend/imagekit/imagekit.go @@ -676,7 +676,7 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op var resp *client.UploadResult - err = o.fs.pacer.Call(func() (bool, error) { + err = o.fs.pacer.CallNoRetry(func() (bool, error) { var res *http.Response res, resp, err = o.fs.ik.Upload(ctx, in, client.UploadParam{ FileName: fileName, @@ -731,7 +731,7 @@ func uploadFile(ctx context.Context, f *Fs, in io.Reader, srcRemote string, opti UseUniqueFileName := new(bool) *UseUniqueFileName = false - err := f.pacer.Call(func() (bool, error) { + err := f.pacer.CallNoRetry(func() (bool, error) { var res *http.Response var err error res, _, err = f.ik.Upload(ctx, in, client.UploadParam{