mirror of
https://github.com/rclone/rclone.git
synced 2025-08-18 09:30:03 +02:00
test: replace defer cleanup with t.Cleanup
Reference: https://pkg.go.dev/testing#T.Cleanup Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
committed by
Nick Craig-Wood
parent
be783a1856
commit
8e507075d1
@@ -111,13 +111,6 @@ func createTestEnvironment(t *testing.T) {
|
||||
var testFolder string
|
||||
var testConfig string
|
||||
|
||||
// removeTestEnvironment removes the test environment created by createTestEnvironment
|
||||
func removeTestEnvironment(t *testing.T) {
|
||||
// Remove temporary folder with all contents
|
||||
err := os.RemoveAll(testFolder)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
|
||||
// createTestFile creates the file testFolder/name
|
||||
func createTestFile(name string, t *testing.T) string {
|
||||
err := os.WriteFile(testFolder+"/"+name, []byte("content_of_"+name), 0666)
|
||||
@@ -146,19 +139,18 @@ func createSimpleTestData(t *testing.T) string {
|
||||
createTestFolder("testdata/folderB", t)
|
||||
createTestFile("testdata/folderB/fileB1.txt", t)
|
||||
createTestFile("testdata/folderB/fileB2.txt", t)
|
||||
return testFolder + "/testdata"
|
||||
}
|
||||
|
||||
// removeSimpleTestData removes the test data created by createSimpleTestData
|
||||
func removeSimpleTestData(t *testing.T) {
|
||||
err := os.RemoveAll(testFolder + "/testdata")
|
||||
require.NoError(t, err)
|
||||
t.Cleanup(func() {
|
||||
err := os.RemoveAll(testFolder + "/testdata")
|
||||
require.NoError(t, err)
|
||||
})
|
||||
|
||||
return testFolder + "/testdata"
|
||||
}
|
||||
|
||||
// TestCmdTest demonstrates and verifies the test functions for end-to-end testing of rclone
|
||||
func TestCmdTest(t *testing.T) {
|
||||
createTestEnvironment(t)
|
||||
defer removeTestEnvironment(t)
|
||||
|
||||
// Test simple call and output from rclone
|
||||
out, err := rclone("version")
|
||||
@@ -213,7 +205,6 @@ func TestCmdTest(t *testing.T) {
|
||||
|
||||
// Test creation of simple test data
|
||||
createSimpleTestData(t)
|
||||
defer removeSimpleTestData(t)
|
||||
|
||||
// Test access to config file and simple test data
|
||||
out, err = rclone("lsl", "myLocal:"+testFolder)
|
||||
|
Reference in New Issue
Block a user