extern/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2024-11-07 17:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

jottacloud: fix scope in token request

Browse Source 
The existing code in rclone set the value "offline_access+openid",
when encoded in body it will become "offline_access%2Bopenid". I think
this is wrong. Probably an artifact of "double urlencoding" mixup -
either in rclone or in the jottacloud cli tool version it was sniffed
from? It does work, though. The token received will have scopes "email
offline_access" in it, and the same is true if I change to only
sending "offline_access" as scope.

If a proper space delimited list of "offline_access openid"
is used in the request, the response also includes openid scope:
"openid email offline_access". I think this is more correct and this
patch implements this.

See: #6107
This commit is contained in:
albertony 2022-04-22 13:52:00 +02:00 committed by GitHub
parent b53c38c9fd
commit b1d43f8d41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
backend/jottacloud/jottacloud.go
View File

@ -519,7 +519,7 @@ func doTokenAuth(ctx context.Context, apiSrv *rest.Client, loginTokenBase64 stri
values.Set("client_id", defaultClientID) values.Set("client_id", defaultClientID)
values.Set("grant_type", "password") values.Set("grant_type", "password")
values.Set("password", loginToken.AuthToken) values.Set("password", loginToken.AuthToken)
values.Set("scope", "offline_access+openid") values.Set("scope", "openid offline_access")
values.Set("username", loginToken.Username) values.Set("username", loginToken.Username)
values.Encode() values.Encode()
opts = rest.Opts{ opts = rest.Opts{