From bb92af693aae2757f977b223cfdcc89f6eb1726e Mon Sep 17 00:00:00 2001 From: albertony <12441419+albertony@users.noreply.github.com> Date: Sun, 21 Aug 2022 16:47:55 +0200 Subject: [PATCH] test: do not test deprecated and unused Dial and DialTLS functions on http Transport type --- lib/structs/structs_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/structs/structs_test.go b/lib/structs/structs_test.go index d9c3bc678..7f742c5c9 100644 --- a/lib/structs/structs_test.go +++ b/lib/structs/structs_test.go @@ -21,9 +21,7 @@ func TestSetDefaults(t *testing.T) { // Check functions by comparing the "%p" representations of them assert.Equal(t, ptr(old.Proxy), ptr(newT.Proxy), "when checking .Proxy") assert.Equal(t, ptr(old.DialContext), ptr(newT.DialContext), "when checking .DialContext") - // Check the other public fields - assert.Equal(t, ptr(old.Dial), ptr(newT.Dial), "when checking .Dial") //lint:ignore SA1019 newT.Dial has been deprecated since Go 1.7: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority. - assert.Equal(t, ptr(old.DialTLS), ptr(newT.DialTLS), "when checking .DialTLS") //lint:ignore SA1019 old.DialTLS has been deprecated since Go 1.14: Use DialTLSContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialTLSContext takes priority. + assert.Equal(t, ptr(old.DialTLSContext), ptr(newT.DialTLSContext), "when checking .DialTLSContext") assert.Equal(t, old.TLSClientConfig, newT.TLSClientConfig, "when checking .TLSClientConfig") assert.Equal(t, old.TLSHandshakeTimeout, newT.TLSHandshakeTimeout, "when checking .TLSHandshakeTimeout") assert.Equal(t, old.DisableKeepAlives, newT.DisableKeepAlives, "when checking .DisableKeepAlives")