From f3680d222c1a932884d10f212e163add4809026d Mon Sep 17 00:00:00 2001 From: nielash Date: Tue, 23 Jan 2024 16:51:07 -0500 Subject: [PATCH] operations: fix TestCaseInsensitiveMoveFileDryRun on chunker integration tests #7591 It appears that ci.DryRun = true affects the behavior of r.WriteObject on chunker only, and no other remotes. This change puts a quick bandaid on it by setting it later on in the test, but perhaps the underlying issue warrants a closer look at some point... is chunker checking ci.DryRun itself in a way that no other remote does? If so, should it? (Does this break encapsulation?) --- fs/operations/operations_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/operations/operations_test.go b/fs/operations/operations_test.go index 325db1748..57cf76d27 100644 --- a/fs/operations/operations_test.go +++ b/fs/operations/operations_test.go @@ -1005,10 +1005,10 @@ func TestCaseInsensitiveMoveFileDryRun(t *testing.T) { return } - ci.DryRun = true file1 := r.WriteObject(ctx, "hello", "world", t1) r.CheckRemoteItems(t, file1) + ci.DryRun = true err := operations.MoveFile(ctx, r.Fremote, r.Fremote, "HELLO", file1.Path) require.NoError(t, err) r.CheckRemoteItems(t, file1)