albertony
20909fa294
build: enable misspell linter
2023-03-26 17:05:24 +02:00
albertony
c502e00c87
fs: fix infinite recursive call in pacer ModifyCalculator (fixes issue reported by the staticcheck linter)
2023-03-26 14:28:15 +02:00
albertony
9172c9b3dd
crypt: reduce allocations
...
This changes crypt's use of sync.Pool: Instead of storing slices
it now stores pointers pointers fixed sized arrays.
This issue was reported by staticcheck:
SA6002 - Storing non-pointer values in sync.Pool allocates memory
A sync.Pool is used to avoid unnecessary allocations and reduce
the amount of work the garbage collector has to do.
When passing a value that is not a pointer to a function that accepts
an interface, the value needs to be placed on the heap, which means
an additional allocation. Slices are a common thing to put in sync.Pools,
and they're structs with 3 fields (length, capacity, and a pointer to
an array). In order to avoid the extra allocation, one should store
a pointer to the slice instead.
See: https://staticcheck.io/docs/checks#SA6002
2023-03-26 14:28:15 +02:00
albertony
78deab05f9
netstorage: ignore false positive from the staticcheck linter regarding header name not being canonical
2023-03-26 14:28:15 +02:00
albertony
6c9d377bbb
vfs: ignore false positive from the unused linter
2023-03-26 14:28:15 +02:00
albertony
62ddc9b7f9
vfscache: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
448ae49fa4
webgui: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
5f3c276d0a
zoho: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
9cea493f58
union: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
400d1a4468
swift: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
851ce0f4fe
seafile: remove unused code for legacy API v2 (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
cc885bd39a
hidrive: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
a1a8c21c70
dropbox: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
6ef4bd8c45
cache: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
fb316123ec
azureblob: remove unused code (fixes issue reported by the unused linter)
2023-03-26 14:28:15 +02:00
albertony
270af61665
smb: code cleanup to avoid overwriting ctx before first use (fixes issue reported by the staticcheck linter)
2023-03-26 14:28:15 +02:00
albertony
155f4f2e21
mount: replace deprecated bazil/fuse specific constants with syscall constants
2023-03-26 14:28:15 +02:00
albertony
eaf593884b
serve/ftp: use io.SeekEnd instead of os.SEEK_END (deprecated since Go 1.7)
2023-03-26 14:28:15 +02:00
albertony
930574c6e9
oracleobjectstorage: remove empty branch (fixes issue reported by the staticcheck linter)
2023-03-26 14:28:15 +02:00
albertony
c1586a9866
onedrive: report any list errors during cleanup
2023-03-26 14:28:15 +02:00
albertony
432eb74814
lib: avoid unnecessary use of fmt.Sprintf for string constant
2023-03-26 14:28:15 +02:00
albertony
92fb644fb6
test: use decompressed.String() instead of string(decompressed.Bytes())
2023-03-26 14:28:15 +02:00
albertony
bb92af693a
test: do not test deprecated and unused Dial and DialTLS functions on http Transport type
2023-03-26 14:28:15 +02:00
albertony
eb5fd07131
mount: error strings should not be capitalized
2023-03-26 14:28:15 +02:00
albertony
b2ce7c9aa6
hidrive: error strings should not be capitalized
2023-03-26 14:28:15 +02:00
albertony
d6b46e41dd
build: replace deprecated linters deadcode, structcheck and varcheckadd with unused
...
The three linters deadcode, structcheck and varcheck we have been using are as of
gitlabci-lint version 1.49.0 (24 Aug 2022) marked as deprecated, and replaced by unused.
The linters staticcheck, gosimple, stylecheck and unused should combined correspond to
the checks performed by the stand-alone staticcheck tool, which is by default used for
linting in Visual Studio Code with the Go extension. We previously enabled the first
three, but skipped unused due to many reported issues.
See #6387 for more information.
2023-03-26 14:28:15 +02:00
albertony
254c6ef1dd
build: add lint ignore comment required for golangci-staticcheck in addition to stand-alone staticcheck
2023-03-26 14:28:15 +02:00
albertony
547f943851
build: exclude known issues from the staticcheck linting in ci
2023-03-26 14:28:15 +02:00
albertony
8611c9f6f7
build: add staticcheck, gosimple and stylecheck linting to the build pipeline - fixes #6273
...
These combined should correspond to the checks performed by the stand-alone
staticcheck tool, which is by default used for linting in Visual Studio Code
with the Go extension. One exception is the unused checks, which staticcheck
tool performs, but chose to not enabled here in rclone due to many reported
occurrences.
See #6387 for more information.
2023-03-26 14:28:15 +02:00
Dimitri Papadopoulos
f6576237a4
fs: fix typos found by codespell
2023-03-25 12:51:04 +01:00
Dimitri Papadopoulos
207b64865e
fstest: fix typo found by codespell
2023-03-25 09:34:10 +01:00
Dimitri Papadopoulos
9ee1b21ec2
vfs: fix typos found by codespell
2023-03-25 09:33:34 +01:00
Dimitri Papadopoulos
55a12bd639
backend: fix repeated words typos
2023-03-25 09:31:36 +01:00
dependabot[bot]
3b4a57dab9
build(deps): bump github.com/aws/aws-sdk-go from 1.44.227 to 1.44.228
...
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go ) from 1.44.227 to 1.44.228.
- [Release notes](https://github.com/aws/aws-sdk-go/releases )
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.227...v1.44.228 )
---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-03-24 20:49:50 +00:00
Dimitri Papadopoulos
afe158f878
docs: fix typos found by codespell
2023-03-24 20:49:00 +00:00
Dimitri Papadopoulos
722a3f32cc
cmdtest: fix typos found by codespell
2023-03-24 20:44:25 +00:00
Dimitri Papadopoulos
9183618082
backend: fix typos found by codespell
2023-03-24 20:42:45 +00:00
Dimitri Papadopoulos
18ebca3979
lib: fix typos found by codespell
2023-03-24 20:40:52 +00:00
Nick Craig-Wood
e84d2c9e5f
docs: add info about # of parallel checks for rclone check/cryptcheck
...
The original commit 7dbf1ab66f
2023-03-24 12:43:45 +00:00
Aditya Basu
e98b61ceeb
docs: update install with docker interactive use
...
* Install with docker: interactive use
* remove extra mount from command
* update listremotes
2023-03-24 11:42:58 +00:00
albertony
19f9fca2f6
docs: document how the configuration file is written, and that an .old file will be deleted
2023-03-24 11:40:34 +00:00
jumbi77
7dbf1ab66f
docs: add info about # of parallel checks for rclone check/cryptcheck
2023-03-24 11:35:58 +00:00
Dimitri Papadopoulos
bfe272bf67
backend: fix typos found by codespell
2023-03-24 11:34:14 +00:00
Dimitri Papadopoulos
cce8936802
cmd: fix typos found by codespell
2023-03-24 11:32:59 +00:00
Juang, Yi-Lin
043bf3567d
drive: update drive service account guide
2023-03-24 11:31:46 +00:00
NickIAm
1b2f2c0d69
docs: add section about --vfs-cache-max-age
...
This change adds a section to clarify how exactly the --vfs-cache-max-age flag affects caching
2023-03-24 11:28:34 +00:00
yuudi
4b376514a6
doc: Clarify the srcFs and dstRs when using local filesystem
...
Co-authored-by: yuudi <yuudi@users.noreply.github.com>
2023-03-24 11:25:39 +00:00
Peter Brunner
c27e6a89b0
drive: add env_auth to drive provider
...
This change provides the ability to pass `env_auth` as a parameter to
the drive provider. This enables the provider to pull IAM
credentials from the environment or instance metadata. Previously if no
auth method was given it would default to requesting oauth.
2023-03-24 11:11:21 +00:00
albertony
76c6e3b15c
build: set Rclone as file description since it is shown as process name in task manager
2023-03-23 18:55:57 +01:00
Nick Craig-Wood
48ec00cc1a
rc: fix missing --rc flags
...
In this commit we accidentally removed the global --rc flags.
0df7466d2b#6675 )
This re-instates them.
2023-03-23 12:05:31 +00:00
