25 Commits

Author	SHA1	Message	Date
Nick Craig-Wood	ffb2e2a6de	config: use --password-command to set config file password if supplied ... Before this change, rclone ignored the --password-command on the rclone config setting except when decrypting an existing config file. This change allows for offloading the password storage/generation into external hardware key or other protected password storage. Fixes #7859	2024-09-06 10:34:29 +01:00
albertony	f8d56bebaf	config: delay load config file (#5258) ... Restructuring of config code in v1.55 resulted in config file being loaded early at process startup. If configuration file is encrypted this means user will need to supply the password, even when running commands that does not use config. This also lead to an issue where mount with --deamon failed to decrypt the config file when it had to prompt user for passord. Fixes #5236 Fixes #5228	2021-04-26 23:37:49 +02:00
albertony	23a0d4a1e6	config: fix issues with memory-only config file paths ... Fixes #5222	2021-04-12 18:17:19 +02:00
Nick Craig-Wood	46078d391f	config: make config file reads reload the config file if needed #4996 ... Before this change the config file needed to be explicitly reloaded. This coupled the config file implementation with the backends needlessly. This change stats the config file to see if it needs to be reloaded on every config file operation. This allows us to remove calls to - config.SaveConfig - config.GetFresh Which now makes the the only needed interface to the config file be that provided by configmap.Map when rclone is not being configured. This also adds tests for configfile	2021-03-14 16:03:35 +00:00
Nick Craig-Wood	6a9ae32012	config: split up main file more and move tests into correct packages ... This splits config.go into ui.go for the user interface functions and authorize.go for the implementation of `rclone authorize`. It also moves the tests into the correct places (including one from obscure which was in the wrong place).	2021-03-11 17:29:26 +00:00
Nick Craig-Wood	1fed2d910c	config: make config file system pluggable ... If you are using rclone a library you can decide to use the rclone config file system or not by calling configfile.LoadConfig(ctx) If you don't you will need to set `config.Data` to an implementation of `config.Storage`. Other changes - change interface of config.FileGet to remove unused default - remove MustValue from config.Storage interface - change GetValue to return string or bool like elsewhere in rclone - implement a default config file system which panics with helpful error - implement getWithDefault to replace the removed MustValue - don't embed goconfig.ConfigFile so we can change the methods	2021-03-11 17:29:26 +00:00
Fionera	c95b580478	config: Wrap config library in an interface	2021-03-11 17:29:26 +00:00
Nick Craig-Wood	2e21c58e6a	fs: deglobalise the config #4685 ... This is done by making fs.Config private and attaching it to the context instead. The Config should be obtained with fs.GetConfig and fs.AddConfig should be used to get a new mutable config that can be changed.	2020-11-26 16:40:12 +00:00
Nick Craig-Wood	f7efce594b	config: add context.Context #3257 #4685 ... This add config to the Config callback in the backends and the related config functions.	2020-11-09 18:05:54 +00:00
Nick Craig-Wood	1fb6ad700f	accounting: add context.Context #3257 #4685	2020-11-09 18:05:54 +00:00
Josh Soref	d0888edc0a	Spelling fixes ... Fix spelling of: above, already, anonymous, associated, authentication, bandwidth, because, between, blocks, calculate, candidates, cautious, changelog, cleaner, clipboard, command, completely, concurrently, considered, constructs, corrupt, current, daemon, dependencies, deprecated, directory, dispatcher, download, eligible, ellipsis, encrypter, endpoint, entrieslist, essentially, existing writers, existing, expires, filesystem, flushing, frequently, hierarchy, however, implementation, implements, inaccurate, individually, insensitive, longer, maximum, metadata, modified, multipart, namedirfirst, nextcloud, obscured, opened, optional, owncloud, pacific, passphrase, password, permanently, persimmon, positive, potato, protocol, quota, receiving, recommends, referring, requires, revisited, satisfied, satisfies, satisfy, semver, serialized, session, storage, strategies, stringlist, successful, supported, surprise, temporarily, temporary, transactions, unneeded, update, uploads, wrapped Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>	2020-10-14 15:21:31 +01:00
Nick Craig-Wood	98c34e413d	config: add --obscure and --no-obscure flags to config create/update ... Before this change there was some ambiguity about whether passwords were obscured on not passing them into config create or config update. This change adds the --obscure and --no-obscure flags to make the intent clear. It also updates the remote control and the tests. Fixes #3728	2020-05-15 16:41:37 +01:00
Nick Craig-Wood	3afb2a4798	config: use SpaceSepList for argument to --password-command ... This is to enable arguments with spaces in.	2020-01-23 15:39:15 +00:00
Nick Craig-Wood	62dbdcdbcc	config: use the environment variable which goes with --password-command	2020-01-23 15:39:15 +00:00
Damon Permezel	06df133159	config: add --password-command to allow dynamic config password - fixes #3694	2020-01-23 15:39:15 +00:00
Nick Craig-Wood	049ff1f269	config: check a remote exists when creating a new one	2019-11-05 12:39:33 +00:00
Nick Craig-Wood	693112d57e	config: Fix generated passwords being stored as empty password - Fixes #3492	2019-08-28 12:11:03 +01:00
Nick Craig-Wood	57d5de6fba	build: fix up package paths after repo move ... git grep -l github.com/ncw/rclone | xargs -d'\n' perl -i~ -lpe 's|github.com/ncw/rclone|github.com/rclone/rclone|g' goimports -w `find . -name \*.go`	2019-07-28 18:47:38 +01:00
Nick Craig-Wood	0ae844d1f8	config: reset environment variables in config file test to fix build	2019-06-22 17:49:23 +01:00
Maran	ba72e62b41	fs/config: Add method to reload configfile from disk ... Fixes #3268	2019-06-19 14:47:54 +01:00
Nick Craig-Wood	903ede52cd	config: make config create/update encrypt passwords where necessary ... Before this change when using "rclone config create" it wasn't possible to add passwords in one go, it was necessary to call "rclone config password" to add the passwords afterwards as "rclone config create" didn't obscure passwords. After this change "rclone config create" and "rclone config update" will obscure passwords as necessary as will the corresponding API calls config/create and config/update. This makes "rclone config password" and its API config/password obsolete, however they will be left for backwards compatibility.	2019-06-10 18:08:55 +01:00
Nick Craig-Wood	8c3740c2c5	config: Improve the Provider matching to have a negated match #2140 ... This makes it easier to make classes of provider in the config.	2018-04-13 16:06:37 +01:00
Stefan	86892467d9	config: load config file only on first access (closes #1659, closes #2096) (#2147)	2018-03-17 12:36:30 +01:00
Nick Craig-Wood	71722b5b95	config: factor Obscure and Reveal into its own package	2018-01-18 20:19:55 +00:00
Nick Craig-Wood	11da2a6c9b	Break the fs package up into smaller parts. ... The purpose of this is to make it easier to maintain and eventually to allow the rclone backends to be re-used in other projects without having to use the rclone configuration system. The new code layout is documented in CONTRIBUTING.	2018-01-15 17:51:14 +00:00