mirror of
https://github.com/rclone/rclone.git
synced 2024-11-07 17:14:44 +01:00
6b7d7d0441
When rclone received a SIGINT (Ctrl+C) or SIGTERM signal while an atexit
function is registered it always terminated with status code 0. Unix
convention is to exit with a non-zero status code. Often it's
`128 + int(signum), but at least not zero.
With this change fatal signals handled by the `atexit` package cause
a non-zero exit code. On Unix systems it's `128 + int(signum)` while
on other systems, such as Windows, it's always 2 ("error not otherwise
categorised").
Resolves #5437.
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
128 lines
2.8 KiB
Go
128 lines
2.8 KiB
Go
// Package atexit provides handling for functions you want called when
|
|
// the program exits unexpectedly due to a signal.
|
|
//
|
|
// You should also make sure you call Run in the normal exit path.
|
|
package atexit
|
|
|
|
import (
|
|
"os"
|
|
"os/signal"
|
|
"sync"
|
|
"sync/atomic"
|
|
|
|
"github.com/rclone/rclone/fs"
|
|
)
|
|
|
|
var (
|
|
fns = make(map[FnHandle]bool)
|
|
fnsMutex sync.Mutex
|
|
exitChan chan os.Signal
|
|
exitOnce sync.Once
|
|
registerOnce sync.Once
|
|
signalled int32
|
|
runCalled int32
|
|
)
|
|
|
|
// FnHandle is the type of the handle returned by function `Register`
|
|
// that can be used to unregister an at-exit function
|
|
type FnHandle *func()
|
|
|
|
// Register a function to be called on exit.
|
|
// Returns a handle which can be used to unregister the function with `Unregister`.
|
|
func Register(fn func()) FnHandle {
|
|
if running() {
|
|
return nil
|
|
}
|
|
fnsMutex.Lock()
|
|
fns[&fn] = true
|
|
fnsMutex.Unlock()
|
|
|
|
// Run AtExit handlers on exitSignals so everything gets tidied up properly
|
|
registerOnce.Do(func() {
|
|
exitChan = make(chan os.Signal, 1)
|
|
signal.Notify(exitChan, exitSignals...)
|
|
go func() {
|
|
sig := <-exitChan
|
|
if sig == nil {
|
|
return
|
|
}
|
|
signal.Stop(exitChan)
|
|
atomic.StoreInt32(&signalled, 1)
|
|
fs.Infof(nil, "Signal received: %s", sig)
|
|
Run()
|
|
fs.Infof(nil, "Exiting...")
|
|
os.Exit(exitCode(sig))
|
|
}()
|
|
})
|
|
|
|
return &fn
|
|
}
|
|
|
|
// Signalled returns true if an exit signal has been received
|
|
func Signalled() bool {
|
|
return atomic.LoadInt32(&signalled) != 0
|
|
}
|
|
|
|
// running returns true if run has been called
|
|
func running() bool {
|
|
return atomic.LoadInt32(&runCalled) != 0
|
|
}
|
|
|
|
// Unregister a function using the handle returned by `Register`
|
|
func Unregister(handle FnHandle) {
|
|
if running() {
|
|
return
|
|
}
|
|
fnsMutex.Lock()
|
|
defer fnsMutex.Unlock()
|
|
delete(fns, handle)
|
|
}
|
|
|
|
// IgnoreSignals disables the signal handler and prevents Run from being executed automatically
|
|
func IgnoreSignals() {
|
|
if running() {
|
|
return
|
|
}
|
|
registerOnce.Do(func() {})
|
|
if exitChan != nil {
|
|
signal.Stop(exitChan)
|
|
close(exitChan)
|
|
exitChan = nil
|
|
}
|
|
}
|
|
|
|
// Run all the at exit functions if they haven't been run already
|
|
func Run() {
|
|
atomic.StoreInt32(&runCalled, 1)
|
|
// Take the lock here (not inside the exitOnce) so we wait
|
|
// until the exit handlers have run before any calls to Run()
|
|
// return.
|
|
fnsMutex.Lock()
|
|
defer fnsMutex.Unlock()
|
|
exitOnce.Do(func() {
|
|
for fnHandle := range fns {
|
|
(*fnHandle)()
|
|
}
|
|
})
|
|
}
|
|
|
|
// OnError registers fn with atexit and returns a function which
|
|
// runs fn() if *perr != nil and deregisters fn
|
|
//
|
|
// It should be used in a defer statement normally so
|
|
//
|
|
// defer OnError(&err, cancelFunc)()
|
|
//
|
|
// So cancelFunc will be run if the function exits with an error or
|
|
// at exit.
|
|
func OnError(perr *error, fn func()) func() {
|
|
handle := Register(fn)
|
|
return func() {
|
|
defer Unregister(handle)
|
|
if *perr != nil {
|
|
fn()
|
|
}
|
|
}
|
|
|
|
}
|