From f9c5b8b0d550a22974e348a1129c19f7c7a240fd Mon Sep 17 00:00:00 2001 From: Tom Eastep Date: Thu, 2 Jun 2011 06:23:37 -0700 Subject: [PATCH 1/3] Improve some comments Signed-off-by: Tom Eastep --- Shorewall/Perl/Shorewall/Chains.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Shorewall/Perl/Shorewall/Chains.pm b/Shorewall/Perl/Shorewall/Chains.pm index db80d1d28..f29e8c870 100644 --- a/Shorewall/Perl/Shorewall/Chains.pm +++ b/Shorewall/Perl/Shorewall/Chains.pm @@ -2920,7 +2920,9 @@ sub record_runtime_address( $ ) { # # If the passed address is a run-time address variable for an optional interface, then -# begin a conditional rule block that tests the address for nil. +# begin a conditional rule block that tests the address for nil. Returns 1 if a conditional +# block was opened. The caller stores the result, and if the result is true the caller +# invokes conditional_rule_end() when the conditional block is complete. # sub conditional_rule( $$ ) { my ( $chainref, $address ) = @_; @@ -2941,7 +2943,8 @@ sub conditional_rule( $$ ) { } # -# If end a conditional in a chain +# End a conditional in a chain begun by conditional_rule(). Should only be called +# if conditional_rule() returned true. # sub conditional_rule_end( $ ) { From 086a99ea24b435141eb9513ce0a36175276ee5b8 Mon Sep 17 00:00:00 2001 From: Tom Eastep Date: Thu, 2 Jun 2011 06:23:57 -0700 Subject: [PATCH 2/3] Don't initialize PLAIN Signed-off-by: Tom Eastep --- Shorewall/install.sh | 1 - Shorewall6/install.sh | 1 - 2 files changed, 2 deletions(-) diff --git a/Shorewall/install.sh b/Shorewall/install.sh index e8c8a4170..26a89933e 100755 --- a/Shorewall/install.sh +++ b/Shorewall/install.sh @@ -106,7 +106,6 @@ if [ -z "$INIT" ] ; then INIT="shorewall" fi -PLAIN= SPARSE= MANDIR=${MANDIR:-"/usr/share/man"} [ -n "${LIBEXEC:=/usr/share}" ] diff --git a/Shorewall6/install.sh b/Shorewall6/install.sh index 403e24825..70ba23732 100755 --- a/Shorewall6/install.sh +++ b/Shorewall6/install.sh @@ -104,7 +104,6 @@ if [ -z "$INIT" ] ; then INIT="shorewall6" fi -PLAIN= DEBIAN= CYGWIN= MAC= From c3600eb81424b4b6f13185806894f61e8845058b Mon Sep 17 00:00:00 2001 From: Tom Eastep Date: Thu, 2 Jun 2011 06:43:23 -0700 Subject: [PATCH 3/3] Document -p and PLAIN Signed-off-by: Tom Eastep --- docs/Install.xml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/docs/Install.xml b/docs/Install.xml index 3929a5601..18acc2965 100644 --- a/docs/Install.xml +++ b/docs/Install.xml @@ -174,6 +174,19 @@ + Beginning with shorewall 4.4.20, the installer also supports a + (plain) option. Beginning with that release, the + standard configuration files (including samples) are annotated with the + contents of the associated manpage. The option + suppresses that behavior such that the configuration files do not include + documentation. + + + Setting the PLAIN environmental + variable to a non-empty value is equivalent to specifying + . + +
Executables in /usr and Perl Modules @@ -267,7 +280,7 @@ For more information about Shorewall usage on Debian system please look at /usr/share/doc/shorewall-common/README.Debian provided by - [the] shorewall-common Debian package. + [the] shorewall Debian package. The easiest way to install Shorewall on Debian, is to use