From 7621859e0ff021a4bf9ceb45cdb8e2355e6d2d69 Mon Sep 17 00:00:00 2001
From: Tom Eastep <teastep@shorewall.net>
Date: Thu, 4 Jun 2009 13:03:56 -0700
Subject: [PATCH] Fix 'findgw'

---
 Shorewall/Perl/prog.header | 2 +-
 Shorewall/changelog.txt    | 2 ++
 Shorewall/releasenotes.txt | 3 +++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/Shorewall/Perl/prog.header b/Shorewall/Perl/prog.header
index 50268bfea..e8dd32d12 100644
--- a/Shorewall/Perl/prog.header
+++ b/Shorewall/Perl/prog.header
@@ -811,7 +811,7 @@ detect_dynamic_gateway() { # $1 = interface
 
     gateway=$(run_findgw_exit $1);
 
-    if [ -n "$gateway" ]; then
+    if [ -z "$gateway" ]; then
 	gateway=$( find_peer $($IP addr list $interface ) )
     fi
 
diff --git a/Shorewall/changelog.txt b/Shorewall/changelog.txt
index e1f3d394f..98833282a 100644
--- a/Shorewall/changelog.txt
+++ b/Shorewall/changelog.txt
@@ -11,6 +11,8 @@ Changes in Shorewall 4.3.12
 
 5) Fix 'reset' command.
 
+6) Fix 'findgw'.
+
 Changes in Shorewall 4.3.11
 
 1) Reduce the number of arguments passed in may cases.
diff --git a/Shorewall/releasenotes.txt b/Shorewall/releasenotes.txt
index bfdb82b6f..fba45657a 100644
--- a/Shorewall/releasenotes.txt
+++ b/Shorewall/releasenotes.txt
@@ -103,6 +103,9 @@ released late in 2009.
 
     	/sbin/shorewall: 885: report: not found
 
+3)  A mis-coded test after the 'findgw' script was executed caused the
+    value returned by that script to be ignored.
+
 ----------------------------------------------------------------------------
              K N O W N   P R O B L E M S   R E M A I N I N G
 ----------------------------------------------------------------------------