diff --git a/Shorewall/Perl/Shorewall/Chains.pm b/Shorewall/Perl/Shorewall/Chains.pm index cbc8fbc09..65d47a3fa 100644 --- a/Shorewall/Perl/Shorewall/Chains.pm +++ b/Shorewall/Perl/Shorewall/Chains.pm @@ -423,9 +423,7 @@ sub add_commands ( $$;@ ) { my $chainref = shift @_; my $indentation = ' ' x $chainref->{cmdlevel}; - for ( @_ ) { - push @{$chainref->{rules}}, join ('', $indentation , $_ ); - } + push @{$chainref->{rules}}, join ('', $indentation , $_ ) for @_; $chainref->{referenced} = 1; } diff --git a/Shorewall/Perl/Shorewall/Tc.pm b/Shorewall/Perl/Shorewall/Tc.pm index e83618af6..71f10c672 100644 --- a/Shorewall/Perl/Shorewall/Tc.pm +++ b/Shorewall/Perl/Shorewall/Tc.pm @@ -651,7 +651,7 @@ sub validate_tc_class( ) { $markval = numeric_value( $mark ); fatal_error "Invalid MARK ($markval)" unless defined $markval; - fatal_error "Invalid Mark ($mark)" unless $markval <= ( $config{WIDE_TC_MARKS} ? 0xffff : 0xff ); + fatal_error "Invalid Mark ($mark)" unless $markval <= ( $config{WIDE_TC_MARKS} ? 0x3fff : 0xff ); if ( $classnumber ) { fatal_error "Duplicate Class NUMBER ($classnumber)" if $tcref->{$classnumber};