From 8cb98f16ea478300b7e4ef16ba84c4db9f0b2a76 Mon Sep 17 00:00:00 2001 From: Tom Eastep Date: Sat, 19 Aug 2017 08:08:24 -0700 Subject: [PATCH] Add a comment in Shorewall::Chains::optimize_level8() Signed-off-by: Tom Eastep --- Shorewall/Perl/Shorewall/Chains.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Shorewall/Perl/Shorewall/Chains.pm b/Shorewall/Perl/Shorewall/Chains.pm index 001b0cde0..42b336345 100644 --- a/Shorewall/Perl/Shorewall/Chains.pm +++ b/Shorewall/Perl/Shorewall/Chains.pm @@ -3900,7 +3900,10 @@ sub optimize_level8( $$$ ) { } $combined{ $chainref1->{name} } = $chainref->{name}; - + # + # While rare, it is possible for a policy chain to be combined with a non-policy chain. So we need to preserve + # the policy attributes in the combined chain + # if ( $chainref->{policychain} ) { @{$chainref1}{qw(policychain policy)} = @{$chainref}{qw(policychain policy)} unless $chainref1->{policychain}; } elsif ( $chainref1->{policychain} ) {