Don't return error status on 'start' if Shorewall[-lite] is already started

git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@4844 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb

Shorewall-lite/shorewall-lite

@@ -193,7 +193,7 @@ start_command() {
 
     if shorewall_is_started; then
 	error_message "Shorewall is already running"
-	exit 1
+	exit 0
     fi
 
     while [ $finished -eq 0 -a $# -gt 0 ]; do

Shorewall/changelog.txt

@@ -21,6 +21,8 @@ Changes in 3.3.5
 
 10) Don't create ingress qdisc if IN-BANDWIDTH = 0.
 
+11) Return success if start of running config.
+
 Changes in 3.3.4
 
 1)  Make exclusion work with "show zones"

Shorewall/prog.footer

@@ -67,7 +67,7 @@ case "$COMMAND" in
     start)
 	if shorewall_is_started; then
 	    error_message "$PRODUCT is already Running"
-	    status=1
+	    status=0
 	else
 	    progress_message3 "Starting $PRODUCT...."
 	    define_firewall

Shorewall/releasenotes.txt

@@ -43,6 +43,10 @@ Problems Corrected in 3.3.5
 3)  Previously, a startup error resulted when white space was included
     in LOGFORMAT.
 
+4)  Previously, the "shorewall[-lite] start" command would return a
+    non-zero exit status if Shorewall [Lite] was already started. It
+    now returns an indication of success.
+
 Other Changes in 3.3.5.
 
 1)  Shorewall no longer includes policy matches in its generated

Shorewall/shorewall

@@ -236,7 +236,7 @@ start_command() {
 
     if shorewall_is_started; then
 	error_message "Shorewall is already running"
-	exit 1
+	exit 0
     fi
 
     if [ -z "$STARTUP_ENABLED" ]; then