From b3598f3766f0e312f52f3a39c340471712592905 Mon Sep 17 00:00:00 2001
From: Tom Eastep <teastep@shorewall.net>
Date: Sun, 2 Jan 2011 07:09:42 -0800
Subject: [PATCH] Validate action names

---
 Shorewall/Perl/Shorewall/Rules.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm
index 5d1005160..9350f4563 100644
--- a/Shorewall/Perl/Shorewall/Rules.pm
+++ b/Shorewall/Perl/Shorewall/Rules.pm
@@ -657,7 +657,7 @@ sub process_actions1() {
 		$action =~ s/:.*$//;
 	    }
 
-	    next unless $action;
+	    fatal_error "Invalid Action Name ($action)" unless $action =~ /^[\w-]+$/;
 
 	    if ( $targets{$action} ) {
 		warning_message "Duplicate Action Name ($action) Ignored" unless $targets{$action} & ACTION;