extern/shorewall_code
1
0
Fork 1
mirror of https://gitlab.com/shorewall/code.git synced 2024-11-23 08:03:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix rule numbers in trace output

Browse Source 
- Don't increment $number needlessly when not tracing

Signed-off-by: Tom Eastep <teastep@shorewall.net>
This commit is contained in:
Tom Eastep 2014-09-27 07:57:09 -07:00
parent 10df9d31c4
commit bc8588a68e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Shorewall/Perl/Shorewall/Chains.pm
View File

@ -1682,14 +1682,16 @@ sub insert_irule( $$$$;@ ) {
$ruleref->{comment} = shortlineinfo( $chainref->{origin} ) || $ruleref->{comment} || $comment; $ruleref->{comment} = shortlineinfo( $chainref->{origin} ) || $ruleref->{comment} || $comment;
if ( $number >= @$rulesref ) { if ( $number >= @$rulesref ) {
push @$rulesref, $ruleref; #
# Avoid failure in spice if we insert beyond the end of the chain
#
$number = @$rulesref; $number = @$rulesref;
push @$rulesref, $ruleref;
} else { } else {
splice( @$rulesref, $number, 0, $ruleref ); splice( @$rulesref, $number, 0, $ruleref );
$number++;
} }
trace( $chainref, 'I', $number, format_rule( $chainref, $ruleref ) ) if $debug; trace( $chainref, 'I', ++$number, format_rule( $chainref, $ruleref ) ) if $debug;
$iprangematch = 0; $iprangematch = 0;