extern/shorewall_code
1
0
Fork 1
mirror of https://gitlab.com/shorewall/code.git synced 2025-06-29 22:21:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Correct handling of unknown ACTION in arprules.

Browse Source 
Signed-off-by: Tom Eastep <teastep@shorewall.net>
This commit is contained in:
Tom Eastep
2013-01-07 18:21:58 -08:00
parent a7af052d91
commit c157228f7d
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Shorewall/Perl/Shorewall/ARP.pm
View File

@ -123,9 +123,12 @@ sub process_arprule() {
fatal_error "The $action ACTION does not allow a new address" unless $action =~ /^SNAT|DNAT|SMAT|DMAT$/; fatal_error "The $action ACTION does not allow a new address" unless $action =~ /^SNAT|DNAT|SMAT|DMAT$/;
} else { } else {
fatal_error "The $action ACTION requires a new address" if $action =~ /^SNAT|DNAT|SMAT|DMAT$/; fatal_error "The $action ACTION requires a new address" if $action =~ /^SNAT|DNAT|SMAT|DMAT$/;
fatal_error "Invalid ACTION ($action)" unless $action =~ /^DROP|ACCEPT$/;
} }
my $function = $functions{$action};
fatal_error "Unknown ACTION ($action)" unless $function;
if ( $source ne '-' ) { if ( $source ne '-' ) {
( $iiface, $saddr, $smac ) = split /:/, $source, 3; ( $iiface, $saddr, $smac ) = split /:/, $source, 3;
@ -169,7 +172,7 @@ sub process_arprule() {
$rule .= $arptablesjf ? " --arpop ${invert}$map[$opcode] " : "--opcode ${invert}$opcode "; $rule .= $arptablesjf ? " --arpop ${invert}$map[$opcode] " : "--opcode ${invert}$opcode ";
} }
$functions{$action} ->(); $function ->();
fatal_error "Either SOURCE or DEST must be specified" unless $chainref; fatal_error "Either SOURCE or DEST must be specified" unless $chainref;