extern/shorewall_code
1
0
Fork 1
mirror of https://gitlab.com/shorewall/code.git synced 2024-11-27 18:13:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add warning when successful tc command returns non-zero exit status

Browse Source
This commit is contained in:
Tom Eastep 2009-05-07 07:19:25 -07:00
parent c9538bbdee
commit d66fc7a7e1
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Shorewall/Perl/Shorewall/Tc.pm
View File

@ -970,9 +970,13 @@ sub setup_traffic_shaping() {
# The following command succeeds yet generates an error message and non-zero exit status :-(. We thus run it silently and check # The following command succeeds yet generates an error message and non-zero exit status :-(. We thus run it silently and check
# the result. Note that since this is normally the first filter added after the root qdisc was added, the 'ls|grep' test is fairly robust # the result. Note that since this is normally the first filter added after the root qdisc was added, the 'ls|grep' test is fairly robust
# #
emit( qq(if ! qt \$TC filter add dev $device parent $devnum:0 prio 65535 protocol ip fw; then) , my $command = "\$TC filter add dev $device parent $devnum:0 prio 65535 protocol ip fw";
qq( if ! \$TC filter list dev $device | grep -q 65535; then) ,
qq( error_message "ERROR: Command '\$TC add dev $device parent $devnum:0 prio 65535 protocol ip fw' failed"), emit( qq(if ! qt $command ; then) ,
qq( if \$TC filter list dev $device | grep -q 65535; then) ,
qq( error_message "WARNING: Command '$command' succeeded but returned non-zero exit status") ,
qq( else),
qq( error_message "ERROR: Command '$command' failed"),
qq( stop_firewall), qq( stop_firewall),
qq( exit 1), qq( exit 1),
qq( fi), qq( fi),