Correct action.TCPFlags

- restore rule dropped when converted.
- remove cruft
- Correct parameter handling

Signed-off-by: Tom Eastep <teastep@shorewall.net>
This commit is contained in:
Tom Eastep 2013-02-08 15:39:04 -08:00
parent 96d64d0a04
commit e664b6bafb

View File

@ -11,7 +11,7 @@
################################################################################# #################################################################################
?FORMAT 2 ?FORMAT 2
DEFAULTS DROP,- DEFAULTS -
?BEGIN PERL; ?BEGIN PERL;
use strict; use strict;
@ -19,16 +19,17 @@ use Shorewall::Config qw(:DEFAULT F_IPV4 F_IPV6);
use Shorewall::Chains; use Shorewall::Chains;
use Shorewall::Rules; use Shorewall::Rules;
my ( $action, $audit ) = get_action_params( 2 ); my $action = 'DROP';
my $chainref = get_action_chain; my ( $audit ) = get_action_params( 1 );
if ( supplied $audit ) { if ( supplied $audit ) {
fatal_error "Invalid parameter ($audit) to action TCPFlags" if $audit ne 'audit'; fatal_error "Invalid parameter ($audit) to action TCPFlags" if $audit ne 'audit';
$action = "A_$action"; $action = "A_DROP";
} }
perl_action_tcp_helper( $action, '-p tcp --tcp-flags ALL FIN,URG,PSH' ); perl_action_tcp_helper( $action, '-p tcp --tcp-flags ALL FIN,URG,PSH' );
perl_action_tcp_helper( $action, '-p tcp --tcp-flags ALL NONE' );
perl_action_tcp_helper( $action, '-p tcp --tcp-flags SYN,RST SYN,RST' ); perl_action_tcp_helper( $action, '-p tcp --tcp-flags SYN,RST SYN,RST' );
perl_action_tcp_helper( $action, '-p tcp --tcp-flags SYN,FIN SYN,FIN' ); perl_action_tcp_helper( $action, '-p tcp --tcp-flags SYN,FIN SYN,FIN' );
perl_action_tcp_helper( $action, '-p tcp --syn --sport 0' ); perl_action_tcp_helper( $action, '-p tcp --syn --sport 0' );