extern/shorewall_code
1
0
Fork 1
mirror of https://gitlab.com/shorewall/code.git synced 2024-11-29 19:13:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Redirect params output to stderr

Browse Source
This commit is contained in:
Tom Eastep 2010-12-01 15:04:33 -08:00
parent f68bfde86f
commit ec75c8aa86
3 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Shorewall/Perl/Shorewall/Config.pm
View File

@ -2894,7 +2894,9 @@ sub get_params() {
progress_message2 "Processing $fn ..."; progress_message2 "Processing $fn ...";
my $command = "$globals{SHAREDIRPL}/getparams $fn " . join( ':', @config_path ); my $command = "$globals{SHAREDIRPL}/getparams $fn " . join( ':', @config_path );
#
# getparams silently sources the params file under 'set -a', then executes 'export -p'
#
my @params = `$command`; my @params = `$command`;
fatal_error "Processing of $fn failed" if $?; fatal_error "Processing of $fn failed" if $?;

2
Shorewall/Perl/getparams
View File

@ -28,7 +28,7 @@ CONFIG_PATH="$2"
set -a set -a
. $1 >/dev/null # Avoid spurious output . $1 >&2 # Avoid spurious output on STDOUT
set +a set +a

13
Shorewall/releasenotes.txt
View File

@ -15,8 +15,12 @@ VI. PROBLEMS CORRECTED AND NEW FEATURES IN PRIOR RELEASES
1) If the output of 'env' contained a multi-line value, then 1) If the output of 'env' contained a multi-line value, then
compilation failed with an Internal Error. The code has been compilation failed with an Internal Error. The code has been
changed so that the compiler now ignores exported symbols with changed so that the compiler now handles multi-line values
a multi-line value. correctly.
2) In 4.4.15, output to Standard Out (FD 2) generated by
/etc/shorewall/params (/etc/shorewall6/params) was redirected to
/dev/null. It is now redirected to Standard Error (FD 2).
---------------------------------------------------------------------------- ----------------------------------------------------------------------------
I I. K N O W N P R O B L E M S R E M A I N I N G I I. K N O W N P R O B L E M S R E M A I N I N G
@ -247,6 +251,11 @@ None.
destination IP address will be included in a later Shorewall destination IP address will be included in a later Shorewall
release. release.
16) If your /etc/shorewall/params (or /etc/shorewall6/params) file
sends output to Standard Output, you need to be aware that the
output will be redirected to Standard Error beginning with
Shorewall 4.4.16.
---------------------------------------------------------------------------- ----------------------------------------------------------------------------
V I. P R O B L E M S C O R R E C T E D A N D N E W F E A T U R E S V I. P R O B L E M S C O R R E C T E D A N D N E W F E A T U R E S
I N P R I O R R E L E A S E S I N P R I O R R E L E A S E S