From 3a25f709e5aa318f40476beae549389c29138170 Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Sun, 16 May 2010 17:55:46 -0400 Subject: [PATCH] log(): don't abort if we fail to write to stderr. Failing to write to the log sucks, but not as much as failing to clean up just because stderr disappeared. So let's catch any IOError exception from log() and just ignore it. This should fix a problem reported by Camille Moncelier, which is that sshuttle firewall entries stick around if your tty dies strangely (eg. your X server aborts for some reason). --- helpers.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/helpers.py b/helpers.py index e43eea2..8793417 100644 --- a/helpers.py +++ b/helpers.py @@ -4,9 +4,14 @@ logprefix = '' verbose = 0 def log(s): - sys.stdout.flush() - sys.stderr.write(logprefix + s) - sys.stderr.flush() + try: + sys.stdout.flush() + sys.stderr.write(logprefix + s) + sys.stderr.flush() + except IOError: + # this could happen if stderr gets forcibly disconnected, eg. because + # our tty closes. That sucks, but it's no reason to abort the program. + pass def debug1(s): if verbose >= 1: