Put all jobs on a global all_jobs list and use that in server.c instead of

running through all the clients.
This commit is contained in:
Nicholas Marriott
2009-10-10 18:42:14 +00:00
parent b7c364a853
commit 095ecf2d90
3 changed files with 12 additions and 36 deletions

View File

@@ -73,9 +73,7 @@ void server_handle_windows(void);
void server_fill_clients(void);
void server_handle_clients(void);
void server_fill_jobs(void);
void server_fill_jobs1(struct jobs *);
void server_handle_jobs(void);
void server_handle_jobs1(struct jobs *);
void server_accept_client(int);
void server_handle_client(struct client *);
void server_handle_window(struct window *, struct window_pane *);
@@ -414,11 +412,7 @@ server_main(int srv_fd)
/* Set window names. */
set_window_names();
/*
* Handle window and client sockets. Clients can create
* windows, so windows must come first to avoid messing up by
* increasing the array size.
*/
/* Handle window and client sockets. */
server_handle_jobs();
server_handle_windows();
server_handle_clients();
@@ -763,23 +757,10 @@ server_fill_clients(void)
/* Fill in job fds. */
void
server_fill_jobs(void)
{
struct client *c;
u_int i;
for (i = 0; i < ARRAY_LENGTH(&clients); i++) {
c = ARRAY_ITEM(&clients, i);
if (c != NULL)
server_fill_jobs1(&c->status_jobs);
}
}
void
server_fill_jobs1(struct jobs *jobs)
{
struct job *job;
RB_FOREACH(job, jobs, jobs) {
SLIST_FOREACH(job, &all_jobs, lentry) {
if (job->fd == -1)
continue;
server_poll_add(job->fd, POLLIN);
@@ -789,24 +770,11 @@ server_fill_jobs1(struct jobs *jobs)
/* Handle job fds. */
void
server_handle_jobs(void)
{
struct client *c;
u_int i;
for (i = 0; i < ARRAY_LENGTH(&clients); i++) {
c = ARRAY_ITEM(&clients, i);
if (c != NULL)
server_handle_jobs1(&c->status_jobs);
}
}
void
server_handle_jobs1(struct jobs *jobs)
{
struct job *job;
struct pollfd *pfd;
RB_FOREACH(job, jobs, jobs) {
SLIST_FOREACH(job, &all_jobs, lentry) {
if (job->fd == -1)
continue;
if ((pfd = server_poll_lookup(job->fd)) == NULL)