extern/tmate
1
0
Fork 0
mirror of https://github.com/tmate-io/tmate.git synced 2025-01-12 17:08:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

A few trivial optimisations: no need to check for zero size if calling

Browse Source 
buffer_ensure in buffer.c; expand grid lines by a greater increase than one
each time; and don't read UTF-8 data unless it actually needs to be checked
when overwriting a cell.
This commit is contained in:
Nicholas Marriott 2009-08-20 19:14:42 +00:00
parent 234ad54b2c
commit 1501b3fbbd
3 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
buffer.c
View File

@ -100,9 +100,6 @@ buffer_remove(struct buffer *b, size_t size)
void void
buffer_write(struct buffer *b, const void *data, size_t size) buffer_write(struct buffer *b, const void *data, size_t size)
{ {
if (size == 0)
fatalx("zero size");
buffer_ensure(b, size); buffer_ensure(b, size);
memcpy(BUFFER_IN(b), data, size); memcpy(BUFFER_IN(b), data, size);
buffer_add(b, size); buffer_add(b, size);
@ -127,7 +124,7 @@ buffer_write8(struct buffer *b, uint8_t n)
{ {
buffer_ensure(b, 1); buffer_ensure(b, 1);
BUFFER_IN(b)[0] = n; BUFFER_IN(b)[0] = n;
buffer_add(b, 1); b->size++;
} }
/* Extract an 8-bit value. */ /* Extract an 8-bit value. */

4
grid.c
View File

@ -198,6 +198,10 @@ grid_expand_line(struct grid *gd, u_int py, u_int sx)
if (sx <= gl->cellsize) if (sx <= gl->cellsize)
return; return;
if (gl->cellsize > gd->sx / 2)
sx = gd->sx;
else
sx = 1 + gl->cellsize * 2;
gl->celldata = xrealloc(gl->celldata, sx, sizeof *gl->celldata); gl->celldata = xrealloc(gl->celldata, sx, sizeof *gl->celldata);
for (xx = gl->cellsize; xx < sx; xx++) for (xx = gl->cellsize; xx < sx; xx++)
grid_put_cell(gd, xx, py, &grid_default_cell); grid_put_cell(gd, xx, py, &grid_default_cell);

26
screen-write.c
View File

@ -858,7 +858,8 @@ screen_write_overwrite(struct screen_write_ctx *ctx)
u_int xx; u_int xx;
gc = grid_view_peek_cell(gd, s->cx, s->cy); gc = grid_view_peek_cell(gd, s->cx, s->cy);
gu = grid_view_peek_utf8(gd, s->cx, s->cy); if (gc->flags & GRID_FLAG_UTF8)
gu = grid_view_peek_utf8(gd, s->cx, s->cy);
if (gc->flags & GRID_FLAG_PADDING) { if (gc->flags & GRID_FLAG_PADDING) {
/* /*
@ -885,16 +886,19 @@ screen_write_overwrite(struct screen_write_ctx *ctx)
break; break;
grid_view_set_cell(gd, xx, s->cy, &grid_default_cell); grid_view_set_cell(gd, xx, s->cy, &grid_default_cell);
} }
} else if (gc->flags & GRID_FLAG_UTF8 && gu->width > 1) { } else if (gc->flags & GRID_FLAG_UTF8) {
/* gu = grid_view_peek_utf8(gd, s->cx, s->cy);
* An UTF-8 wide cell; overwrite following padding cells only. if (gu->width > 1) {
*/ /*
xx = s->cx; * An UTF-8 wide cell; overwrite following padding cells only.
while (++xx < screen_size_x(s)) { */
gc = grid_view_peek_cell(gd, xx, s->cy); xx = s->cx;
if (!(gc->flags & GRID_FLAG_PADDING)) while (++xx < screen_size_x(s)) {
break; gc = grid_view_peek_cell(gd, xx, s->cy);
grid_view_set_cell(gd, xx, s->cy, &grid_default_cell); if (!(gc->flags & GRID_FLAG_PADDING))
break;
grid_view_set_cell(gd, xx, s->cy, &grid_default_cell);
}
} }
} }
} }