From 423649b2c61eaa976490bfa331b35cec7de92d48 Mon Sep 17 00:00:00 2001 From: Nicholas Marriott Date: Tue, 30 Aug 2011 09:18:52 +0000 Subject: [PATCH] Plug memory leak, from Tiago Cunha. --- cmd-split-window.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/cmd-split-window.c b/cmd-split-window.c index e34645a4..31654771 100644 --- a/cmd-split-window.c +++ b/cmd-split-window.c @@ -58,7 +58,7 @@ cmd_split_window_exec(struct cmd *self, struct cmd_ctx *ctx) struct window *w; struct window_pane *wp, *new_wp = NULL; struct environ env; - char *cmd, *cwd, *cause; + char *cmd, *cwd, *cause, *new_cause; const char *shell; u_int hlimit, paneidx; int size, percentage; @@ -94,16 +94,18 @@ cmd_split_window_exec(struct cmd *self, struct cmd_ctx *ctx) if (args_has(args, 'l')) { size = args_strtonum(args, 'l', 0, INT_MAX, &cause); if (cause != NULL) { - ctx->error(ctx, "size %s", cause); + xasprintf(&new_cause, "size %s", cause); xfree(cause); - return (-1); + cause = new_cause; + goto error; } } else if (args_has(args, 'p')) { percentage = args_strtonum(args, 'p', 0, INT_MAX, &cause); if (cause != NULL) { - ctx->error(ctx, "percentage %s", cause); + xasprintf(&new_cause, "percentage %s", cause); xfree(cause); - return (-1); + cause = new_cause; + goto error; } if (type == LAYOUT_TOPBOTTOM) size = (wp->sy * percentage) / 100;