From ac5b7d518e78ed21ed8a9757f5ea3f49f407d232 Mon Sep 17 00:00:00 2001
From: Nicholas Marriott <nicm@openbsd.org>
Date: Thu, 19 Nov 2009 10:22:06 +0000
Subject: [PATCH] Don't interpret #() for display-message, it usually doesn't
 make sense and may leak commands.

---
 cmd-display-message.c |  2 +-
 server-client.c       |  2 +-
 status.c              | 30 ++++++++++++++++++++++--------
 tmux.1                |  9 +++++----
 tmux.h                |  2 +-
 5 files changed, 30 insertions(+), 15 deletions(-)

diff --git a/cmd-display-message.c b/cmd-display-message.c
index 1ff5718b..be39857d 100644
--- a/cmd-display-message.c
+++ b/cmd-display-message.c
@@ -55,7 +55,7 @@ cmd_display_message_exec(struct cmd *self, struct cmd_ctx *ctx)
 	else
 		template = data->arg;
 
-	msg = status_replace(c, template, time(NULL));
+	msg = status_replace(c, template, time(NULL), 0);
 	status_message_set(c, "%s", msg);
 	xfree(msg);
 
diff --git a/server-client.c b/server-client.c
index 8ff71223..7334d4b4 100644
--- a/server-client.c
+++ b/server-client.c
@@ -489,7 +489,7 @@ server_client_set_title(struct client *c)
 
 	template = options_get_string(&s->options, "set-titles-string");
 	
-	title = status_replace(c, template, time(NULL));
+	title = status_replace(c, template, time(NULL), 1);
 	if (c->title == NULL || strcmp(title, c->title) != 0) {
 		if (c->title != NULL)
 			xfree(c->title);
diff --git a/status.c b/status.c
index a5716d1a..968f3634 100644
--- a/status.c
+++ b/status.c
@@ -107,14 +107,14 @@ status_redraw(struct client *c)
 
 	/* Work out the left and right strings. */
 	left = status_replace(c, options_get_string(
-	    &s->options, "status-left"), c->status_timer.tv_sec);
+	    &s->options, "status-left"), c->status_timer.tv_sec, 1);
 	llen = options_get_number(&s->options, "status-left-length");
 	llen2 = screen_write_cstrlen(utf8flag, "%s", left);
 	if (llen2 < llen)
 		llen = llen2;
 
 	right = status_replace(c, options_get_string(
-	    &s->options, "status-right"), c->status_timer.tv_sec);
+	    &s->options, "status-right"), c->status_timer.tv_sec, 1);
 	rlen = options_get_number(&s->options, "status-right-length");
 	rlen2 = screen_write_cstrlen(utf8flag, "%s", right);
 	if (rlen2 < rlen)
@@ -319,7 +319,7 @@ out:
 }
 
 char *
-status_replace(struct client *c, const char *fmt, time_t t)
+status_replace(struct client *c, const char *fmt, time_t t, int run_jobs)
 {
 	struct session *s = c->session;
 	struct winlink *wl = s->curw;
@@ -355,11 +355,25 @@ status_replace(struct client *c, const char *fmt, time_t t)
 			ptr = NULL;
 			switch (*iptr++) {
 			case '(':
-				if (ptr == NULL) {
-					ptr = status_job(c, &iptr);
-					if (ptr == NULL)
-						break;
-					savedptr = ptr;
+				if (run_jobs) {
+					if (ptr == NULL) {
+						ptr = status_job(c, &iptr);
+						if (ptr == NULL)
+							break;
+						savedptr = ptr;
+					}
+				} else {
+					/* Don't run jobs. Copy to ). */
+					*optr++ = '#';
+
+					iptr--;	/* include [ */
+					while (*iptr != ')' && *iptr != '\0') {
+						if (optr >=
+						    out + (sizeof out) - 1)
+							break;
+						*optr++ = *iptr++;
+					}
+					break;
 				}
 				/* FALLTHROUGH */
 			case 'H':
diff --git a/tmux.1 b/tmux.1
index 2b356db1..3c550876 100644
--- a/tmux.1
+++ b/tmux.1
@@ -1992,10 +1992,11 @@ This command works only from inside
 .Op Ar message
 .Xc
 .D1 (alias: Ic display )
-Display a message (see the
-.Ic status-left
-option below)
-in the status line.
+Display a message in the status line.
+The format of
+.Ar message is as for
+.Ic status-left ,
+with the exception that #() are not handled.
 .It Ic select-prompt Op Fl t Ar target-client
 Open a prompt inside
 .Ar target-client
diff --git a/tmux.h b/tmux.h
index 517fe9d4..78869274 100644
--- a/tmux.h
+++ b/tmux.h
@@ -1617,7 +1617,7 @@ void	 server_update_event(struct client *);
 
 /* status.c */
 int	 status_redraw(struct client *);
-char	*status_replace(struct client *, const char *, time_t);
+char	*status_replace(struct client *, const char *, time_t, int);
 void printflike2 status_message_set(struct client *, const char *, ...);
 void	 status_message_clear(struct client *);
 int	 status_message_redraw(struct client *);