mirror of
https://github.com/tmate-io/tmate.git
synced 2025-08-16 08:38:12 +02:00
Call realpath earlier on the socket directory path rather than on the
socket file path because the latter may not exist yet and in that case realpath is allowed to fail. From Romain Francoise.
This commit is contained in:
8
tmux.c
8
tmux.c
@ -159,7 +159,7 @@ parseenvironment(void)
|
||||
char *
|
||||
makesocketpath(const char *label)
|
||||
{
|
||||
char base[MAXPATHLEN], *path, *s;
|
||||
char base[MAXPATHLEN], realbase[MAXPATHLEN], *path, *s;
|
||||
struct stat sb;
|
||||
u_int uid;
|
||||
|
||||
@ -183,7 +183,10 @@ makesocketpath(const char *label)
|
||||
return (NULL);
|
||||
}
|
||||
|
||||
xasprintf(&path, "%s/%s", base, label);
|
||||
if (realpath(base, realbase) == NULL)
|
||||
strlcpy(realbase, base, sizeof realbase);
|
||||
|
||||
xasprintf(&path, "%s/%s", realbase, label);
|
||||
return (path);
|
||||
}
|
||||
|
||||
@ -384,7 +387,6 @@ main(int argc, char **argv)
|
||||
}
|
||||
}
|
||||
free(label);
|
||||
if (realpath(path, socket_path) == NULL)
|
||||
strlcpy(socket_path, path, sizeof socket_path);
|
||||
free(path);
|
||||
|
||||
|
Reference in New Issue
Block a user