From cb8db0b1f5bc9e52b17512b64dce46dc4f6b5e69 Mon Sep 17 00:00:00 2001
From: Alicia Sykes <alicia@omg.lol>
Date: Sat, 18 May 2024 15:01:52 +0100
Subject: [PATCH] JSON parsing in API endpoints

---
 api/linked-pages.js | 4 ++--
 api/mail-config.js  | 4 +++-
 api/tls.js          | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/api/linked-pages.js b/api/linked-pages.js
index 750d54f..e576d3a 100644
--- a/api/linked-pages.js
+++ b/api/linked-pages.js
@@ -33,12 +33,12 @@ const linkedPagesHandler = async (url) => {
   if (internalLinks.length === 0 && externalLinks.length === 0) {
     return {
       statusCode: 400,
-      body: JSON.stringify({
+      body: {
         skipped: 'No internal or external links found. '
           + 'This may be due to the website being dynamically rendered, using a client-side framework (like React), and without SSR enabled. '
           + 'That would mean that the static HTML returned from the HTTP request doesn\'t contain any meaningful content for Web-Check to analyze. '
           + 'You can rectify this by using a headless browser to render the page instead.',
-        }),
+        },
     };
   }
 
diff --git a/api/mail-config.js b/api/mail-config.js
index 0d430f9..1c8aff8 100644
--- a/api/mail-config.js
+++ b/api/mail-config.js
@@ -2,6 +2,8 @@ import dns from 'dns';
 import URL from 'url-parse';
 import middleware from './_common/middleware.js';
 
+// TODO: Fix.
+
 const mailConfigHandler = async (url, event, context) => {
   try {
     const domain = new URL(url).hostname || new URL(url).pathname;
@@ -70,7 +72,7 @@ const mailConfigHandler = async (url, event, context) => {
     } else {
       return {
         statusCode: 500,
-        body: JSON.stringify({ error: error.message }),
+        body: { error: error.message },
       };
     }
   }
diff --git a/api/tls.js b/api/tls.js
index 7d5a117..5249f6f 100644
--- a/api/tls.js
+++ b/api/tls.js
@@ -12,13 +12,13 @@ const tlsHandler = async (url) => {
     if (typeof scanId !== 'number') {
       return {
         statusCode: 500,
-        body: JSON.stringify({ error: 'Failed to get scan_id from TLS Observatory' }),
+        body: { error: 'Failed to get scan_id from TLS Observatory' },
       };
     }
     const resultResponse = await axios.get(`${MOZILLA_TLS_OBSERVATORY_API}/results?id=${scanId}`);
     return {
       statusCode: 200,
-      body: JSON.stringify(resultResponse.data),
+      body: resultResponse.data,
     };
   } catch (error) {
     return { error: error.message };