From f8abbeb2346bb2659a9729c69478b548e26cdabe Mon Sep 17 00:00:00 2001
From: KITAITI Makoto <KitaitiMakoto@gmail.com>
Date: Fri, 27 Jun 2025 11:41:26 +0900
Subject: [PATCH] ruby : add Whisper::VERSION (#3292)

* Add a test for segment

* Check option existence

* Use more proper variable to define build option

* Assert Core ML enabled

* Define Whisper::VERSION

* Add test for Whisper::VERSION

* Add signature of Whisper::VERSION
---
 bindings/ruby/ext/options.rb       |  9 ++++++---
 bindings/ruby/ext/ruby_whisper.c   |  1 +
 bindings/ruby/sig/whisper.rbs      |  1 +
 bindings/ruby/test/test_package.rb |  3 ++-
 bindings/ruby/test/test_segment.rb | 10 ++++++++++
 bindings/ruby/test/test_whisper.rb |  4 ++++
 6 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/bindings/ruby/ext/options.rb b/bindings/ruby/ext/options.rb
index 30cda0f8..ede80c06 100644
--- a/bindings/ruby/ext/options.rb
+++ b/bindings/ruby/ext/options.rb
@@ -64,7 +64,7 @@ class Options
   def configure_coreml
     if enabled?("WHISPER_COREML")
       $LDFLAGS << " -framework Foundation -framework CoreML"
-      $CPPFLAGS << " -DRUBY_WHISPER_USE_COREML"
+      $defs << "-DRUBY_WHISPER_USE_COREML"
     end
   end
 
@@ -73,10 +73,13 @@ class Options
   end
 
   def enabled?(option)
-    if @options[option][1].nil?
+    op = @options[option]
+    raise "Option not exist: #{option}" unless op
+    raise "Option not boolean: #{option}(#{op[0]})" unless op[0] == "BOOL"
+    if op[1].nil?
       cmake_options[option][1]
     else
-      @options[option][1]
+      op[1]
     end
   end
 end
diff --git a/bindings/ruby/ext/ruby_whisper.c b/bindings/ruby/ext/ruby_whisper.c
index 35c196ab..533bda74 100644
--- a/bindings/ruby/ext/ruby_whisper.c
+++ b/bindings/ruby/ext/ruby_whisper.c
@@ -148,6 +148,7 @@ void Init_whisper() {
   mWhisper = rb_define_module("Whisper");
   mVAD = rb_define_module_under(mWhisper, "VAD");
 
+  rb_define_const(mWhisper, "VERSION", rb_str_new2(whisper_version()));
   rb_define_const(mWhisper, "LOG_LEVEL_NONE", INT2NUM(GGML_LOG_LEVEL_NONE));
   rb_define_const(mWhisper, "LOG_LEVEL_INFO", INT2NUM(GGML_LOG_LEVEL_INFO));
   rb_define_const(mWhisper, "LOG_LEVEL_WARN", INT2NUM(GGML_LOG_LEVEL_WARN));
diff --git a/bindings/ruby/sig/whisper.rbs b/bindings/ruby/sig/whisper.rbs
index e6c0e139..5966ce31 100644
--- a/bindings/ruby/sig/whisper.rbs
+++ b/bindings/ruby/sig/whisper.rbs
@@ -10,6 +10,7 @@ module Whisper
   type encoder_begin_callback = ^(Whisper::Context, void, Object user_data) -> void
   type abort_callback = ^(Whisper::Context, void, Object user_data) -> boolish
 
+  VERSION: String
   LOG_LEVEL_NONE: Integer
   LOG_LEVEL_INFO: Integer
   LOG_LEVEL_WARN: Integer
diff --git a/bindings/ruby/test/test_package.rb b/bindings/ruby/test/test_package.rb
index 33cd2a3c..108f34ef 100644
--- a/bindings/ruby/test/test_package.rb
+++ b/bindings/ruby/test/test_package.rb
@@ -31,10 +31,11 @@ class TestPackage < TestBase
         Dir.mktmpdir do |dir|
           system "gem", "install", "--install-dir", dir.shellescape, "--no-document", "pkg/#{gemspec.file_name.shellescape}", "--", "--enable-whisper-coreml", exception: true
           assert_installed dir, gemspec.version
+          libdir = File.join(dir, "gems", "#{gemspec.name}-#{gemspec.version}", "lib")
           assert_nothing_raised do
-            libdir = File.join(dir, "gems", "#{gemspec.name}-#{gemspec.version}", "lib")
             system "ruby", "-I", libdir, "-r", "whisper", "-e", "Whisper::Context.new('tiny')", exception: true
           end
+          assert_match(/COREML = 1/, `ruby -I #{libdir.shellescape} -r whisper -e 'puts Whisper.system_info_str'`)
         end
       end
     end
diff --git a/bindings/ruby/test/test_segment.rb b/bindings/ruby/test/test_segment.rb
index 5b63e0c4..cb4ba9eb 100644
--- a/bindings/ruby/test/test_segment.rb
+++ b/bindings/ruby/test/test_segment.rb
@@ -72,6 +72,16 @@ class TestSegment < TestBase
     whisper.transcribe(AUDIO, params)
   end
 
+  def test_transcription_after_segment_retrieved
+    params = Whisper::Params.new
+    segment = whisper.each_segment.first
+    assert_match(/ask not what your country can do for you, ask what you can do for your country/, segment.text)
+
+    whisper.transcribe(AUDIO, Whisper::Params.new(offset: 5000))
+    assert_not_match(/ask not what your country can do for you, ask what you can do for your country/, segment.text)
+    assert_match(/what you can do for your country/i, segment.text)
+  end
+
   def test_pattern_matching
     segment = whisper.each_segment.first
     segment => {start_time:, end_time:, text:, no_speech_prob:, speaker_turn_next:}
diff --git a/bindings/ruby/test/test_whisper.rb b/bindings/ruby/test/test_whisper.rb
index e429c543..12b82a8d 100644
--- a/bindings/ruby/test/test_whisper.rb
+++ b/bindings/ruby/test/test_whisper.rb
@@ -116,6 +116,10 @@ class TestWhisper < TestBase
     assert_match(/\AWHISPER : COREML = \d | OPENVINO = \d |/, Whisper.system_info_str)
   end
 
+  def test_version
+    assert_kind_of String, Whisper::VERSION
+  end
+
   def test_log_set
     user_data = Object.new
     logs = []