extern/zfs-auto-snapshot
1
0
Fork 1
mirror of https://github.com/zfsonlinux/zfs-auto-snapshot.git synced 2024-11-29 03:23:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

Consistently quote literal strings.

Browse Source 
Apply some syntax hygiene. Quoting everything is a safe habit because
unquoted things can have subtle side-effects.
This commit is contained in:
Darik Horn 2011-11-22 23:36:51 -06:00
parent 249e6a4cb3
commit 4c14da4130
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/zfs-auto-snapshot.sh
View File

@ -43,7 +43,7 @@ DESTRUCTION_COUNT='0'
SNAPSHOT_COUNT='0' SNAPSHOT_COUNT='0'
WARNING_COUNT='0' WARNING_COUNT='0'
# Global variables. # Other global variables.
SNAPSHOTS_OLD='' SNAPSHOTS_OLD=''
@ -125,7 +125,7 @@ do_run () # [argv]
else else
eval $* eval $*
RC="$?" RC="$?"
if [ "$RC" -eq 0 ] if [ "$RC" -eq '0' ]
then then
print_log debug "$*" print_log debug "$*"
else else
@ -154,9 +154,9 @@ do_snapshots () # properties, flags, snapname, oldglob, [targets...]
do do
if do_run "zfs snapshot $PROPERTIES $FLAGS '$ii@$NAME'" if do_run "zfs snapshot $PROPERTIES $FLAGS '$ii@$NAME'"
then then
SNAPSHOT_COUNT=$(( $SNAPSHOT_COUNT +1 )) SNAPSHOT_COUNT=$(( $SNAPSHOT_COUNT + 1 ))
else else
WARNING_COUNT=$(( $WARNING_COUNT +1 )) WARNING_COUNT=$(( $WARNING_COUNT + 1 ))
continue continue
fi fi
@ -172,11 +172,11 @@ do_snapshots () # properties, flags, snapname, oldglob, [targets...]
if [ -z "${jj#$ii@$GLOB}" ] if [ -z "${jj#$ii@$GLOB}" ]
then then
KEEP=$(( $KEEP - 1 )) KEEP=$(( $KEEP - 1 ))
if [ "$KEEP" -le 0 ] if [ "$KEEP" -le '0' ]
then then
if do_run "zfs destroy $FLAGS '$jj'" if do_run "zfs destroy $FLAGS '$jj'"
then then
DESTRUCTION_COUNT=$(( $DESTRUCTION_COUNT +1 )) DESTRUCTION_COUNT=$(( $DESTRUCTION_COUNT + 1 ))
else else
WARNING_COUNT=$(( $WARNING_COUNT + 1 )) WARNING_COUNT=$(( $WARNING_COUNT + 1 ))
fi fi
@ -200,13 +200,13 @@ GETOPT=$(getopt \
eval set -- "$GETOPT" eval set -- "$GETOPT"
while [ "$#" -gt 0 ] while [ "$#" -gt '0' ]
do do
case "$1" in case "$1" in
(-d|--debug) (-d|--debug)
opt_debug=1 opt_debug='1'
opt_quiet='' opt_quiet=''
opt_verbose=1 opt_verbose='1'
shift 1 shift 1
;; ;;
(--default-exclude) (--default-exclude)
@ -218,7 +218,7 @@ do
shift 1 shift 1
;; ;;
(-s|--skip-scrub) (-s|--skip-scrub)
opt_skip_scrub=1 opt_skip_scrub='1'
shift 1 shift 1
;; ;;
(-h|--help) (-h|--help)
@ -226,7 +226,7 @@ do
exit 0 exit 0
;; ;;
(-k|--keep) (-k|--keep)
if ! test "$2" -gt 0 2>/dev/null if ! test "$2" -gt '0' 2>/dev/null
then then
print_log error "The $1 parameter must be a positive integer." print_log error "The $1 parameter must be a positive integer."
exit 2 exit 2
@ -249,7 +249,7 @@ do
shift 1 shift 1
;; ;;
(-r|--recursive) (-r|--recursive)
opt_recursive=1 opt_recursive='1'
shift 1 shift 1
;; ;;
(--sep) (--sep)
@ -264,18 +264,18 @@ do
(*) (*)
print_log error "The $1 parameter must be one alphanumeric character." print_log error "The $1 parameter must be one alphanumeric character."
exit 4 exit 4
;; ;;
esac esac
opt_sep="$2" opt_sep="$2"
shift 2 shift 2
;; ;;
(-g|--syslog) (-g|--syslog)
opt_syslog=1 opt_syslog='1'
shift 1 shift 1
;; ;;
(-v|--verbose) (-v|--verbose)
opt_quiet='' opt_quiet=''
opt_verbose=1 opt_verbose='1'
shift 1 shift 1
;; ;;
(--) (--)
@ -285,7 +285,7 @@ do
esac esac
done done
if [ "$#" -eq 0 ] if [ "$#" -eq '0' ]
then then
print_log error "The filesystem argument list is empty." print_log error "The filesystem argument list is empty."
exit 5 exit 5
@ -298,7 +298,7 @@ do
test "$ii" = '//' && SLASHIES=$(( $SLASHIES + 1 )) test "$ii" = '//' && SLASHIES=$(( $SLASHIES + 1 ))
done done
if [ "$#" -gt 1 -a "$SLASHIES" -gt 0 ] if [ "$#" -gt '1' -a "$SLASHIES" -gt '0' ]
then then
print_log error "The // must be the only argument if it is given." print_log error "The // must be the only argument if it is given."
exit 6 exit 6