application-wide logging through Logger interface

cmd/main.go

@@ -11,9 +11,14 @@ import (
 	"time"
 )
 
+type Logger interface {
+	Printf(format string, v ...interface{})
+}
+
 var conf Config
 var runner *jobrun.JobRunner
 var logFlags int = log.LUTC | log.Ldate | log.Ltime
+var defaultLog Logger
 
 func main() {
 
@@ -26,6 +31,9 @@ func main() {
 		cli.StringFlag{Name: "config"},
 	}
 	app.Before = func(c *cli.Context) (err error) {
+
+		defaultLog = log.New(os.Stderr, "", logFlags)
+
 		if !c.GlobalIsSet("config") {
 			return errors.New("config flag not set")
 		}

scratchpad/chunker/main.go

@@ -7,8 +7,8 @@ import (
 	// "bytes"
 	_ "bufio"
 	// "strings"
-	"fmt"
 	"io"
+	"log"
 	"os"
 	_ "time"
 )
@@ -44,7 +44,7 @@ func main() {
 			panic(err)
 		}
 
-		fmt.Fprintf(os.Stderr, "Chunk Count: %d\n", chunker.ChunkCount)
+		log.Printf("Chunk Count: %d\n", chunker.ChunkCount)
 
 	case *mode == "outgoing":
 
@@ -72,7 +72,7 @@ func main() {
 
 		conn.Close()
 
-		fmt.Fprintf(os.Stderr, "Chunk Count: %d\n", unchunker.ChunkCount)
+		log.Printf("Chunk Count: %d\n", unchunker.ChunkCount)
 
 		os.Exit(0)
 

sshbytestream/ssh.go

@@ -115,7 +115,6 @@ func Outgoing(remote SSHTransport) (conn io.ReadWriteCloser, err error) {
 				Stderr:  stderrBuf.Bytes(),
 				WaitErr: err,
 			}
-			// fmt.Fprintf(os.Stderr, "ssh conn wait err: %#v\n", f.SSHCommandError.(Error))
 		} else {
 			f.SSHCommandError = nil
 		}