extern/zrepl
1
0
Fork 0
mirror of https://github.com/zrepl/zrepl.git synced 2025-06-29 06:01:24 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

zfs: allow spaces in zfs names.

Browse Source 
Space is a allowed character in zfs names accoring to
https://github.com/zfsonlinux/zfs/issues/439.
This commit is contained in:
Moritz Fago 2018-06-19 19:51:40 +02:00 committed by Christian Schwarz
parent c7f0f779b1
commit 302d77cf4a
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
zfs/zfs.go
View File

@ -107,8 +107,14 @@ func NewDatasetPath(s string) (p *DatasetPath, err error) {
p.comps = make([]string, 0) p.comps = make([]string, 0)
return p, nil // the empty dataset path return p, nil // the empty dataset path
} }
const FORBIDDEN = "@#|\t <>*" const FORBIDDEN = "@#|\t<>*"
if strings.ContainsAny(s, FORBIDDEN) { // TODO space may be a bit too restrictive... /* Documenation of allowed characters in zfs names:
https://docs.oracle.com/cd/E19253-01/819-5461/gbcpt/index.html
Space is missing in the oracle list, but according to
https://github.com/zfsonlinux/zfs/issues/439
there is evidence that it was intentionally allowed
*/
if strings.ContainsAny(s, FORBIDDEN) {
err = fmt.Errorf("contains forbidden characters (any of '%s')", FORBIDDEN) err = fmt.Errorf("contains forbidden characters (any of '%s')", FORBIDDEN)
return return
} }