extern/zrepl
1
0
Fork 0
mirror of https://github.com/zrepl/zrepl.git synced 2025-08-18 18:58:15 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

pruner: improve cancellation + error handling strategy

Browse Source 
Pruner now backs off as soon as there is an error, making that error the
Error field in the pruner report.
The error is also stored in the specific *fs that failed, and we
maintain an error counter per *fs to de-prioritize those fs that failed.
Like with replication, the de-prioritization on errors is to avoid '
getting stuck' with an individual filesystem until the watchdog hits.
This commit is contained in:
Christian Schwarz
2018-10-20 12:35:24 +02:00
parent 50c1549865
commit 438f950be3
4 changed files with 175 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
client/status.go
View File

@@ -391,8 +391,8 @@ func (t *tui) renderPrunerReport(r *pruner.Report) {
for _, fs := range all {
t.write(rightPad(fs.Filesystem, maxFSname, " "))
t.write(" ")
if fs.Error != "" {
t.printf("ERROR: %s\n", fs.Error) // whitespace is padding
if fs.LastError != "" {
t.printf("ERROR (%d): %s\n", fs.LastError) // whitespace is padding
continue
}
@@ -400,11 +400,11 @@ func (t *tui) renderPrunerReport(r *pruner.Report) {
len(fs.DestroyList), len(fs.SnapshotList))
if fs.completed {
t.printf( "Completed %s\n", pruneRuleActionStr)
t.printf( "Completed %s\n", pruneRuleActionStr)
continue
}
t.write("Pending ") // whitespace is padding 10
t.write("Pending ") // whitespace is padding 10
if len(fs.DestroyList) == 1 {
t.write(fs.DestroyList[0].Name)
} else {