cmd: remove legacy NoMatchError

cmd/config_mapfilter.go

@@ -1,7 +1,6 @@
 package cmd
 
 import (
-	"errors"
 	"fmt"
 	"strings"
 
@@ -24,8 +23,6 @@ type datasetMapFilterEntry struct {
 	subtreeMatch bool
 }
 
-var NoMatchError error = errors.New("no match found in mapping")
-
 func NewDatasetMapFilter(capacity int, filterOnly bool) DatasetMapFilter {
 	return DatasetMapFilter{
 		entries:    make([]datasetMapFilterEntry, 0, capacity),
@@ -111,7 +108,7 @@ func (m DatasetMapFilter) Map(source *zfs.DatasetPath) (target *zfs.DatasetPath,
 
 	mi, hasMapping := m.mostSpecificPrefixMapping(source)
 	if !hasMapping {
-		err = NoMatchError
+		return nil, nil
 		return
 	}
 	me := m.entries[mi]

cmd/replication.go

@@ -184,11 +184,11 @@ func doPull(pull PullContext) (err error) {
 		var localFs *zfs.DatasetPath
 		localFs, err = pull.Mapping.Map(remoteFilesystems[fs])
 		if err != nil {
-			if err != NoMatchError {
-				err := fmt.Errorf("error mapping %s: %s", remoteFilesystems[fs], err)
-				log.Printf("%s", err)
-				return err
-			}
+			err := fmt.Errorf("error mapping %s: %s", remoteFilesystems[fs], err)
+			log.Printf("%s", err)
+			return err
+		}
+		if localFs == nil {
 			continue
 		}
 		log.Printf("%s => %s", remoteFilesystems[fs].ToString(), localFs.ToString())

cmd/test.go

@@ -84,7 +84,11 @@ func doTestDatasetMapFilter(cmd *cobra.Command, args []string) {
 			log.Printf("error evaluating mapping: %s", err)
 			os.Exit(1)
 		}
-		log.Printf("%s => %s", ip.ToString(), res.ToString())
+		toStr := "NO MAPPING"
+		if res != nil {
+			toStr = res.ToString()
+		}
+		log.Printf("%s => %s", ip.ToString(), toStr)
 
 	}