extern/zrepl
1
0
Fork 0
mirror of https://github.com/zrepl/zrepl.git synced 2024-11-22 08:23:50 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

[#347] package trace: printing debugString before instead of at panic (fixup e500d9e)

Browse Source
This commit is contained in:
Christian Schwarz 2020-08-29 19:14:21 +02:00
parent 3a4e841c73
commit a7915db4c3
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
daemon/logging/trace/trace.go
View File

@ -93,6 +93,7 @@ package trace
import ( import (
"context" "context"
"fmt" "fmt"
"os"
runtimedebug "runtime/debug" runtimedebug "runtime/debug"
"strings" "strings"
"time" "time"
@ -241,7 +242,11 @@ func WithTask(ctx context.Context, taskName string) (context.Context, DoneFunc)
defer this.mtx.Lock().Unlock() defer this.mtx.Lock().Unlock()
if this.activeChildTasks != 0 { if this.activeChildTasks != 0 {
panic(errors.WithMessagef(ErrTaskStillHasActiveChildTasks, "end task: %v active child tasks\n: %s", this.activeChildTasks, this.debugString())) if debugEnabled {
// the debugString can be quite long and panic won't print it completely
fmt.Fprintf(os.Stderr, "going to panic due to activeChildTasks:\n%s\n", this.debugString())
}
panic(errors.WithMessagef(ErrTaskStillHasActiveChildTasks, "end task: %v active child tasks\n", this.activeChildTasks))
} }
// support idempotent task ends // support idempotent task ends
@ -256,7 +261,11 @@ func WithTask(ctx context.Context, taskName string) (context.Context, DoneFunc)
delete(this.parentTask.debugActiveChildTasks, this) delete(this.parentTask.debugActiveChildTasks, this)
} }
if this.parentTask.activeChildTasks < 0 { if this.parentTask.activeChildTasks < 0 {
panic(fmt.Sprintf("impl error: parent task with negative activeChildTasks count: %s", this.debugString())) if debugEnabled {
// the debugString can be quite long and panic won't print it completely
fmt.Fprintf(os.Stderr, "going to panic due to activeChildTasks < 0:\n%s\n", this.parentTask.debugString())
}
panic(fmt.Sprintf("impl error: parent task with negative activeChildTasks count: %v", this.parentTask.activeChildTasks))
} }
} }
return false return false