From c9b812570d7d0b7fb3dcc9fc24085b590a76bcf8 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Mon, 18 Mar 2019 12:30:19 +0100 Subject: [PATCH] docs: changelog: document new rpc & retry behavior changes --- README.md | 22 +++++++++++++++++----- docs/changelog.rst | 29 ++++++++++++++++++----------- docs/configuration/jobs.rst | 2 ++ 3 files changed, 37 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 4feb862..5eecf36 100644 --- a/README.md +++ b/README.md @@ -58,8 +58,6 @@ Make sure to develop an understanding how zrepl is typically used by studying th │   ├── prometheus │   ├── pruner # pruner implementation │   ├── snapper # snapshotter implementation -│   ├── streamrpcconfig # abstraction for configuration of go-streamrpc -│   └── transport # transports implementation ├── docs # sphinx-based documentation │   ├── **/*.rst # documentation in reStructuredText │   ├── sphinxconf @@ -71,10 +69,24 @@ Make sure to develop an understanding how zrepl is typically used by studying th ├── logger # our own logger package ├── pruning # pruning rules (the logic, not the actual execution) │   └── retentiongrid -├── replication # the fsm that implements replication of multiple file systems -│   ├── fsrep # replication of a single filesystem -│   └── pdu # the protobuf-generated structs + helpers passed to an endpoint +├── replication +│ ├── driver # the driver of the replication logic (status reporting, error handling) +│ ├── logic # planning & executing replication steps via rpc +| |   └── pdu # the generated gRPC & protobuf code used in replication (and endpoints) +│ └── report # the JSON-serializable report datastructures exposed to the client +├── rpc # the hybrid gRPC + ./dataconn RPC client: connects to a remote replication.Endpoint +│ ├── dataconn # Bulk data-transfer RPC protocol +│ ├── grpcclientidentity # adaptor to inject package transport's 'client identity' concept into gRPC contexts +│ ├── netadaptor # adaptor to convert a package transport's Connecter and Listener into net.* primitives +│ ├── transportmux # TCP connecter and listener used to split control & data traffic +│ └── versionhandshake # replication protocol version handshake perfomed on newly established connections ├── tlsconf # abstraction for Go TLS server + client config +├── transport # transports implementation +│ ├── fromconfig +│ ├── local +│ ├── ssh +│ ├── tcp +│ └── tls ├── util ├── vendor # managed by dep ├── version # abstraction for versions (filled during build by Makefile) diff --git a/docs/changelog.rst b/docs/changelog.rst index a821e3c..b6d3823 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -48,9 +48,6 @@ Notes to Package Maintainers This functionality will cause SIGABRT on panics and can be used to capture a coredump of the panicking process. To that extend, make sure that your package build system, your OS's coredump collection and the Go delve debugger work together. Use your build system to package the Go program in `this tutorial on Go coredumps and the delve debugger `_ , and make sure the symbol resolution etc. work on coredumps captured from the binary produced by your build system. (Special focus on symbol stripping, etc.) -* Use of ``ssh+stdinserver`` :ref:`transport ` is no longer encouraged. - Please encourage users to use the new ``tcp`` or ``tls`` transports. - You might as well mention some of the :ref:`tunneling options listed here `. Changes ~~~~~~~ @@ -58,16 +55,26 @@ Changes * |feature| :issue:`55` : Push replication (see :ref:`push job ` and :ref:`sink job `) * |feature| :ref:`TCP Transport ` * |feature| :ref:`TCP + TLS client authentication transport ` -* |feature| :issue:`78` :commit:`074f989` : Replication protocol rewrite +* |feature| :issue:`111`: RPC protocol rewrite - * Uses ``github.com/problame/go-streamrpc`` for RPC layer - * |break| Protocol breakage, update and restart of all zrepl daemons is required - * |feature| :issue:`83`: Improved error handling of network-level errors (zrepl retries instead of failing the entire job) - * |bugfix| :issue:`75` :issue:`81`: use connection timeouts and protocol-level heartbeats - * |break| |break_config|: mappings are no longer supported + * |break| Protocol breakage; Update and restart of all zrepl daemons is required. + * Use `gRPC `_ for control RPCs and a custom protocol for bulk data transfer. + * Automatic retries for network-temporary errors - * Receiving sides (``pull`` and ``sink`` job) specify a single ``root_fs``. - Received filesystems are then stored *per client* in ``${root_fs}/${client_identity}``. + * Limited to errors during replication for this release. + Addresses the common problem of ISP-forced reconnection at night, but will become + way more useful with resumable send & recv support. + Pruning errors are handled per FS, i.e., a prune RPC is attempted at least once per FS. + +* |feature| Proper timeout handling for the :ref:`SSH transport ` + + * |break| Requires Go 1.11 or later. + +* |break| |break_config|: mappings are no longer supported + + * Receiving sides (``pull`` and ``sink`` job) specify a single ``root_fs``. + Received filesystems are then stored *per client* in ``${root_fs}/${client_identity}``. + See :ref:`job-overview` for details. * |feature| |break| |break_config| Manual snapshotting + triggering of replication diff --git a/docs/configuration/jobs.rst b/docs/configuration/jobs.rst index 15911ca..ccc62df 100644 --- a/docs/configuration/jobs.rst +++ b/docs/configuration/jobs.rst @@ -11,6 +11,8 @@ Job Types & Replication ======================= +.. _job-overview: + Overview & Terminology ----------------------