extern/zrepl
1
0
Fork 0
mirror of https://github.com/zrepl/zrepl.git synced 2024-11-24 09:24:09 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

lint: add lint checking for time.Equal (#841)

Browse Source 
No issues found, tested that the lint works by changing code locally.

fixes https://github.com/zrepl/zrepl/issues/5
This commit is contained in:
Christian Schwarz 2024-11-02 15:45:09 +01:00 committed by GitHub
parent 2923009689
commit dc05cd00f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.golangci.yml
View File

@ -1,7 +1,12 @@
linters: linters:
enable: enable:
- goimports - goimports
- revive
linters-settings:
revive:
rules:
- name: time-equal
issues: issues:
exclude-rules: exclude-rules:
- path: _test\.go - path: _test\.go

2
internal/zfs/versions.go
View File

@ -122,7 +122,7 @@ func (v FilesystemVersion) String() string { return v.RelName() }
// are immutable over time in ZFS. // are immutable over time in ZFS.
func FilesystemVersionEqualIdentity(a, b FilesystemVersion) bool { func FilesystemVersionEqualIdentity(a, b FilesystemVersion) bool {
// .Name is mutable // .Name is mutable
return a.Guid == b.Guid && a.CreateTXG == b.CreateTXG && a.Creation == b.Creation return a.Guid == b.Guid && a.CreateTXG == b.CreateTXG && a.Creation.Equal(b.Creation)
} }
func (v FilesystemVersion) ToAbsPath(p *DatasetPath) string { func (v FilesystemVersion) ToAbsPath(p *DatasetPath) string {