mirror of
https://github.com/zrepl/zrepl.git
synced 2024-11-25 01:44:43 +01:00
1ae087bfcf
- make `logging.GetLogger(ctx, Subsys)` the authoritative `logger.Logger` factory function
- the context carries a linked list of injected fields which
`logging.GetLogger` adds to the logger it returns
- introduce the concept of tasks and spans, also tracked as linked list within ctx
- [ ] TODO automatic logging of span begins and ends, with a unique
ID stack that makes it easy to follow a series of log entries in
concurrent code
- ability to produce a chrome://tracing-compatible trace file,
either via an env variable or a `zrepl pprof` subcommand
- this is not a CPU profile, we already have go pprof for that
- but it is very useful to visually inspect where the
replication / snapshotter / pruner spends its time
( fixes #307 )
100 lines
2.0 KiB
Go
100 lines
2.0 KiB
Go
package client
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"sync"
|
|
|
|
"github.com/fatih/color"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/pflag"
|
|
|
|
"github.com/zrepl/zrepl/cli"
|
|
"github.com/zrepl/zrepl/endpoint"
|
|
"github.com/zrepl/zrepl/util/chainlock"
|
|
)
|
|
|
|
var zabsListFlags struct {
|
|
Filter zabsFilterFlags
|
|
Json bool
|
|
}
|
|
|
|
var zabsCmdList = &cli.Subcommand{
|
|
Use: "list",
|
|
Short: `list zrepl ZFS abstractions`,
|
|
Run: doZabsList,
|
|
NoRequireConfig: true,
|
|
SetupFlags: func(f *pflag.FlagSet) {
|
|
zabsListFlags.Filter.registerZabsFilterFlags(f, "list")
|
|
f.BoolVar(&zabsListFlags.Json, "json", false, "emit JSON")
|
|
},
|
|
}
|
|
|
|
func doZabsList(ctx context.Context, sc *cli.Subcommand, args []string) error {
|
|
var err error
|
|
|
|
if len(args) > 0 {
|
|
return errors.New("this subcommand takes no positional arguments")
|
|
}
|
|
|
|
q, err := zabsListFlags.Filter.Query()
|
|
if err != nil {
|
|
return errors.Wrap(err, "invalid filter specification on command line")
|
|
}
|
|
|
|
abstractions, errors, err := endpoint.ListAbstractionsStreamed(ctx, q)
|
|
if err != nil {
|
|
return err // context clear by invocation of command
|
|
}
|
|
|
|
var line chainlock.L
|
|
var wg sync.WaitGroup
|
|
defer wg.Wait()
|
|
wg.Add(1)
|
|
|
|
// print results
|
|
go func() {
|
|
defer wg.Done()
|
|
enc := json.NewEncoder(os.Stdout)
|
|
for a := range abstractions {
|
|
func() {
|
|
defer line.Lock().Unlock()
|
|
if zabsListFlags.Json {
|
|
enc.SetIndent("", " ")
|
|
if err := enc.Encode(abstractions); err != nil {
|
|
panic(err)
|
|
}
|
|
fmt.Println()
|
|
} else {
|
|
fmt.Println(a)
|
|
}
|
|
}()
|
|
}
|
|
}()
|
|
|
|
// print errors to stderr
|
|
errorColor := color.New(color.FgRed)
|
|
var errorsSlice []endpoint.ListAbstractionsError
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
for err := range errors {
|
|
func() {
|
|
defer line.Lock().Unlock()
|
|
errorsSlice = append(errorsSlice, err)
|
|
errorColor.Fprintf(os.Stderr, "%s\n", err)
|
|
}()
|
|
}
|
|
}()
|
|
wg.Wait()
|
|
if len(errorsSlice) > 0 {
|
|
errorColor.Add(color.Bold).Fprintf(os.Stderr, "there were errors in listing the abstractions")
|
|
return fmt.Errorf("")
|
|
} else {
|
|
return nil
|
|
}
|
|
|
|
}
|