mirror of
https://github.com/zrepl/zrepl.git
synced 2024-11-25 18:04:58 +01:00
aed6149c8c
fixup of 96e188d7c4
refs #196
refs #301
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x9a472a]
goroutine 15826 [running]:
os.(*ProcessState).systemTime(...)
/home/cs/go1.13/src/os/exec_unix.go:98
os.(*ProcessState).SystemTime(...)
/home/cs/go1.13/src/os/exec.go:141
github.com/zrepl/zrepl/zfs/zfscmd.waitPostPrometheus(0xc000c04800, 0xe21ce0, 0xc000068270, 0xbf9f80d88107e861, 0x19bae710e6, 0x13a8b60)
/home/cs/zrepl/zrepl/zfs/zfscmd/zfscmd_prometheus.go:69 +0x22a
github.com/zrepl/zrepl/zfs/zfscmd.(*Cmd).waitPost(0xc000c04800, 0xe21ce0, 0xc000068270)
/home/cs/zrepl/zrepl/zfs/zfscmd/zfscmd.go:155 +0x18a
github.com/zrepl/zrepl/zfs/zfscmd.(*Cmd).CombinedOutput(0xc000c04800, 0xc0004b8270, 0xd02eea, 0x3, 0xc0001f6c40, 0x3)
/home/cs/zrepl/zrepl/zfs/zfscmd/zfscmd.go:40 +0xb3
github.com/zrepl/zrepl/zfs.ZFSRelease(0xe36aa0, 0xc0004b8270, 0xc0009a3a40, 0x13, 0xc0004a5d00, 0x1, 0x1, 0xed62eb221, 0x13a8b60)
/home/cs/zrepl/zrepl/zfs/holds.go:102 +0x2a7
github.com/zrepl/zrepl/endpoint.ReleaseStep(0xe36aa0, 0xc0004b8270, 0xc0004befc0, 0xe, 0xd08482, 0x8, 0xc0001cb02f, 0x2, 0x1eeea3bff89dc90b, 0x134d6, ...)
/home/cs/zrepl/zrepl/endpoint/endpoint_zfs_abstraction_step.go:130 +0x367
github.com/zrepl/zrepl/endpoint.(*Sender).SendCompleted.func2(0xc000459190, 0xc000390e30, 0xc00041fd80, 0xc0004befc0, 0xe, 0xd08482, 0x8, 0xc0001cb02f, 0x2, 0x1eeea3bff89dc90b, ...)
/home/cs/zrepl/zrepl/endpoint/endpoint.go:419 +0x1c3
created by github.com/zrepl/zrepl/endpoint.(*Sender).SendCompleted
/home/cs/zrepl/zrepl/endpoint/endpoint.go:413 +0x776
190 lines
3.8 KiB
Go
190 lines
3.8 KiB
Go
// Package zfscmd provides a wrapper around packate os/exec.
|
|
// Functionality provided by the wrapper:
|
|
// - logging start and end of command execution
|
|
// - status report of active commands
|
|
// - prometheus metrics of runtimes
|
|
package zfscmd
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/zrepl/zrepl/util/circlog"
|
|
)
|
|
|
|
type Cmd struct {
|
|
cmd *exec.Cmd
|
|
ctx context.Context
|
|
mtx sync.RWMutex
|
|
startedAt, waitStartedAt, waitReturnedAt time.Time
|
|
}
|
|
|
|
func CommandContext(ctx context.Context, name string, arg ...string) *Cmd {
|
|
cmd := exec.CommandContext(ctx, name, arg...)
|
|
return &Cmd{cmd: cmd, ctx: ctx}
|
|
}
|
|
|
|
// err.(*exec.ExitError).Stderr will NOT be set
|
|
func (c *Cmd) CombinedOutput() (o []byte, err error) {
|
|
c.startPre()
|
|
c.startPost(nil)
|
|
c.waitPre()
|
|
o, err = c.cmd.CombinedOutput()
|
|
c.waitPost(err)
|
|
return
|
|
}
|
|
|
|
// err.(*exec.ExitError).Stderr will be set
|
|
func (c *Cmd) Output() (o []byte, err error) {
|
|
c.startPre()
|
|
c.startPost(nil)
|
|
c.waitPre()
|
|
o, err = c.cmd.Output()
|
|
c.waitPost(err)
|
|
return
|
|
}
|
|
|
|
// Careful: err.(*exec.ExitError).Stderr will not be set, even if you don't open an StderrPipe
|
|
func (c *Cmd) StdoutPipeWithErrorBuf() (p io.ReadCloser, errBuf *circlog.CircularLog, err error) {
|
|
p, err = c.cmd.StdoutPipe()
|
|
errBuf = circlog.MustNewCircularLog(1 << 15)
|
|
c.cmd.Stderr = errBuf
|
|
return p, errBuf, err
|
|
}
|
|
|
|
type Stdio struct {
|
|
Stdin io.ReadCloser
|
|
Stdout io.Writer
|
|
Stderr io.Writer
|
|
}
|
|
|
|
func (c *Cmd) SetStdio(stdio Stdio) {
|
|
c.cmd.Stdin = stdio.Stdin
|
|
c.cmd.Stderr = stdio.Stderr
|
|
c.cmd.Stdout = stdio.Stdout
|
|
}
|
|
|
|
func (c *Cmd) String() string {
|
|
return strings.Join(c.cmd.Args, " ") // includes argv[0] if initialized with CommandContext, that's the only way we o it
|
|
}
|
|
|
|
func (c *Cmd) log() Logger {
|
|
return getLogger(c.ctx).WithField("cmd", c.String())
|
|
}
|
|
|
|
func (c *Cmd) Start() (err error) {
|
|
c.startPre()
|
|
err = c.cmd.Start()
|
|
c.startPost(err)
|
|
return err
|
|
}
|
|
|
|
// only call this after a successful call to .Start()
|
|
func (c *Cmd) Process() *os.Process {
|
|
if c.startedAt.IsZero() {
|
|
panic("calling Process() only allowed after successful call to Start()")
|
|
}
|
|
return c.cmd.Process
|
|
}
|
|
|
|
func (c *Cmd) Wait() (err error) {
|
|
c.waitPre()
|
|
err = c.cmd.Wait()
|
|
if !c.waitReturnedAt.IsZero() {
|
|
// ignore duplicate waits
|
|
return err
|
|
}
|
|
c.waitPost(err)
|
|
return err
|
|
}
|
|
|
|
func (c *Cmd) startPre() {
|
|
startPreLogging(c, time.Now())
|
|
}
|
|
|
|
func (c *Cmd) startPost(err error) {
|
|
now := time.Now()
|
|
|
|
c.mtx.Lock()
|
|
c.startedAt = now
|
|
c.mtx.Unlock()
|
|
|
|
startPostReport(c, err, now)
|
|
startPostLogging(c, err, now)
|
|
}
|
|
|
|
func (c *Cmd) waitPre() {
|
|
now := time.Now()
|
|
|
|
// ignore duplicate waits
|
|
c.mtx.Lock()
|
|
// ignore duplicate waits
|
|
if !c.waitStartedAt.IsZero() {
|
|
c.mtx.Unlock()
|
|
return
|
|
}
|
|
c.waitStartedAt = now
|
|
c.mtx.Unlock()
|
|
|
|
waitPreLogging(c, now)
|
|
}
|
|
|
|
type usage struct {
|
|
total_secs, system_secs, user_secs float64
|
|
}
|
|
|
|
func (c *Cmd) waitPost(err error) {
|
|
now := time.Now()
|
|
|
|
c.mtx.Lock()
|
|
// ignore duplicate waits
|
|
if !c.waitReturnedAt.IsZero() {
|
|
c.mtx.Unlock()
|
|
return
|
|
}
|
|
c.waitReturnedAt = now
|
|
c.mtx.Unlock()
|
|
|
|
// build usage
|
|
var u usage
|
|
{
|
|
var s *os.ProcessState
|
|
if err == nil {
|
|
s = c.cmd.ProcessState
|
|
} else if ee, ok := err.(*exec.ExitError); ok {
|
|
s = ee.ProcessState
|
|
}
|
|
|
|
if s == nil {
|
|
u = usage{
|
|
total_secs: c.Runtime().Seconds(),
|
|
system_secs: -1,
|
|
user_secs: -1,
|
|
}
|
|
} else {
|
|
u = usage{
|
|
total_secs: c.Runtime().Seconds(),
|
|
system_secs: s.SystemTime().Seconds(),
|
|
user_secs: s.UserTime().Seconds(),
|
|
}
|
|
}
|
|
}
|
|
|
|
waitPostReport(c, u, now)
|
|
waitPostLogging(c, u, err, now)
|
|
waitPostPrometheus(c, u, err, now)
|
|
}
|
|
|
|
// returns 0 if the command did not yet finish
|
|
func (c *Cmd) Runtime() time.Duration {
|
|
if c.waitReturnedAt.IsZero() {
|
|
return 0
|
|
}
|
|
return c.waitReturnedAt.Sub(c.startedAt)
|
|
}
|