mirror of
https://github.com/zrepl/zrepl.git
synced 2024-11-26 10:25:05 +01:00
1ae087bfcf
- make `logging.GetLogger(ctx, Subsys)` the authoritative `logger.Logger` factory function
- the context carries a linked list of injected fields which
`logging.GetLogger` adds to the logger it returns
- introduce the concept of tasks and spans, also tracked as linked list within ctx
- [ ] TODO automatic logging of span begins and ends, with a unique
ID stack that makes it easy to follow a series of log entries in
concurrent code
- ability to produce a chrome://tracing-compatible trace file,
either via an env variable or a `zrepl pprof` subcommand
- this is not a CPU profile, we already have go pprof for that
- but it is very useful to visually inspect where the
replication / snapshotter / pruner spends its time
( fixes #307 )
33 lines
594 B
Go
33 lines
594 B
Go
package zfscmd
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/zrepl/zrepl/daemon/logging"
|
|
"github.com/zrepl/zrepl/logger"
|
|
)
|
|
|
|
type contextKey int
|
|
|
|
const (
|
|
contextKeyJobID contextKey = 1 + iota
|
|
)
|
|
|
|
type Logger = logger.Logger
|
|
|
|
func WithJobID(ctx context.Context, jobID string) context.Context {
|
|
return context.WithValue(ctx, contextKeyJobID, jobID)
|
|
}
|
|
|
|
func getJobIDOrDefault(ctx context.Context, def string) string {
|
|
ret, ok := ctx.Value(contextKeyJobID).(string)
|
|
if !ok {
|
|
return def
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func getLogger(ctx context.Context) Logger {
|
|
return logging.GetLogger(ctx, logging.SubsysZFSCmd)
|
|
}
|