mirror of
https://github.com/zrepl/zrepl.git
synced 2024-11-22 00:13:52 +01:00
27012e5623
Because some jobs add client identity to root_fs and other jobs don't do
that,
we can't reliable detect overlapping of filesystems. And and the same
time we
need an ability to use equal or overlapped root_fs for different jobs.
For
instance see this config:
```
- name: "zdisk"
type: "sink"
root_fs: "zdisk/zrepl"
serve:
type: "local"
listener_name: "zdisk"
```
and
```
- name: "remote-to-zdisk"
type: "pull"
connect:
type: "tls"
root_fs: "zdisk/zrepl/remote"
```
As you can see, two jobs have overlapped root_fs, but actually datasets
are not
overlapped, because job `zdisk` save everything under
`zdisk/zrepl/localhost`,
because it adds client identity. So they actually use two different
filesystems:
`zdisk/zrepl/localhost` and `zdisk/zrepl/remote`. And we can't detect
this
situation during config check. So let's just remove this check, because
it's
admin's duty to configure correct root_fs's.
---------
Co-authored-by: Christian Schwarz <me@cschwarz.com>
106 lines
2.8 KiB
Go
106 lines
2.8 KiB
Go
package job
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/zrepl/zrepl/config"
|
|
"github.com/zrepl/zrepl/util/bandwidthlimit"
|
|
)
|
|
|
|
func JobsFromConfig(c *config.Config, parseFlags config.ParseFlags) ([]Job, error) {
|
|
js := make([]Job, len(c.Jobs))
|
|
for i := range c.Jobs {
|
|
j, err := buildJob(c.Global, c.Jobs[i], parseFlags)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if j == nil || j.Name() == "" {
|
|
panic(fmt.Sprintf("implementation error: job builder returned nil job type %T", c.Jobs[i].Ret))
|
|
}
|
|
js[i] = j
|
|
}
|
|
|
|
return js, nil
|
|
}
|
|
|
|
func buildJob(c *config.Global, in config.JobEnum, parseFlags config.ParseFlags) (j Job, err error) {
|
|
cannotBuildJob := func(e error, name string) (Job, error) {
|
|
return nil, errors.Wrapf(e, "cannot build job %q", name)
|
|
}
|
|
// FIXME prettify this
|
|
switch v := in.Ret.(type) {
|
|
case *config.SinkJob:
|
|
j, err = passiveSideFromConfig(c, &v.PassiveJob, v, parseFlags)
|
|
if err != nil {
|
|
return cannotBuildJob(err, v.Name)
|
|
}
|
|
case *config.SourceJob:
|
|
j, err = passiveSideFromConfig(c, &v.PassiveJob, v, parseFlags)
|
|
if err != nil {
|
|
return cannotBuildJob(err, v.Name)
|
|
}
|
|
case *config.SnapJob:
|
|
j, err = snapJobFromConfig(c, v)
|
|
if err != nil {
|
|
return cannotBuildJob(err, v.Name)
|
|
}
|
|
case *config.PushJob:
|
|
j, err = activeSide(c, &v.ActiveJob, v, parseFlags)
|
|
if err != nil {
|
|
return cannotBuildJob(err, v.Name)
|
|
}
|
|
case *config.PullJob:
|
|
j, err = activeSide(c, &v.ActiveJob, v, parseFlags)
|
|
if err != nil {
|
|
return cannotBuildJob(err, v.Name)
|
|
}
|
|
default:
|
|
panic(fmt.Sprintf("implementation error: unknown job type %T", v))
|
|
}
|
|
return j, nil
|
|
|
|
}
|
|
|
|
func validateReceivingSidesDoNotOverlap(receivingRootFSs []string) error {
|
|
if len(receivingRootFSs) == 0 {
|
|
return nil
|
|
}
|
|
rfss := make([]string, len(receivingRootFSs))
|
|
copy(rfss, receivingRootFSs)
|
|
sort.Slice(rfss, func(i, j int) bool {
|
|
return strings.Compare(rfss[i], rfss[j]) == -1
|
|
})
|
|
// add tailing slash because of hierarchy-simulation
|
|
// rootfs/ is not root of rootfs2/
|
|
for i := 0; i < len(rfss); i++ {
|
|
rfss[i] += "/"
|
|
}
|
|
// idea:
|
|
// no path in rfss must be prefix of another
|
|
//
|
|
// rfss is now lexicographically sorted, which means that
|
|
// if i is prefix of j, i < j (in lexicographical order)
|
|
// thus,
|
|
// if any i is prefix of i+n (n >= 1), there is overlap
|
|
for i := 0; i < len(rfss)-1; i++ {
|
|
if strings.HasPrefix(rfss[i+1], rfss[i]) {
|
|
return fmt.Errorf("receiving jobs with overlapping root filesystems are forbidden")
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func buildBandwidthLimitConfig(in *config.BandwidthLimit) (c bandwidthlimit.Config, _ error) {
|
|
if in.Max.ToBytes() > 0 && int64(in.Max.ToBytes()) == 0 {
|
|
return c, fmt.Errorf("bandwidth limit `max` is too small, must at least specify one byte")
|
|
}
|
|
return bandwidthlimit.Config{
|
|
Max: int64(in.Max.ToBytes()),
|
|
BucketCapacity: int64(in.BucketCapacity.ToBytes()),
|
|
}, nil
|
|
}
|