mirror of
https://github.com/zrepl/zrepl.git
synced 2025-03-02 01:01:28 +01:00
b33f670b9d
- drop HintMostRecentCommonAncestor rpc call
- it is wrong to put faith into the active side of the replication to always make that call
(we might not trust it, ref pull setup)
- clean up step holds + step bookmarks + replication cursor bookmarks on
send RPC instead
- this makes it symmetric with Receive RPC
- use a cache (endpoint.sendAbstractionsCache) to avoid the cost of
listing the on-disk endpoint abstractions state on every step
The "create" methods for endpoint abstractions (CreateReplicationCursor, HoldStep) are now fully
idempotent and return an Abstraction.
Notes about endpoint.sendAbstractionsCache:
- fills lazily from disk state on first `Get` operation
- fill from disk is generally only attempted once
- unless the `ListAbstractions` fails, in which case the fill from
disk is retried on next `Get` (the current `Get` will observe a
subset of the actual on-disk abstractions)
- the `Invalidate` method is called
- it is a global (zrepl process-wide) cache
fixes #316
96 lines
3.2 KiB
Go
96 lines
3.2 KiB
Go
package tests
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/zrepl/zrepl/endpoint"
|
|
"github.com/zrepl/zrepl/platformtest"
|
|
"github.com/zrepl/zrepl/zfs"
|
|
)
|
|
|
|
func ReplicationCursor(ctx *platformtest.Context) {
|
|
|
|
platformtest.Run(ctx, platformtest.PanicErr, ctx.RootDataset, `
|
|
CREATEROOT
|
|
+ "foo bar"
|
|
+ "foo bar@1 with space"
|
|
R zfs bookmark "${ROOTDS}/foo bar@1 with space" "${ROOTDS}/foo bar#1 with space"
|
|
+ "foo bar@2 with space"
|
|
R zfs bookmark "${ROOTDS}/foo bar@2 with space" "${ROOTDS}/foo bar#2 with space"
|
|
+ "foo bar@3 with space"
|
|
R zfs bookmark "${ROOTDS}/foo bar@3 with space" "${ROOTDS}/foo bar#3 with space"
|
|
`)
|
|
|
|
jobid := endpoint.MustMakeJobID("zreplplatformtest")
|
|
|
|
ds, err := zfs.NewDatasetPath(ctx.RootDataset + "/foo bar")
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
fs := ds.ToString()
|
|
|
|
checkCreateCursor := func(createErr error, c endpoint.Abstraction, references zfs.FilesystemVersion) {
|
|
assert.NoError(ctx, createErr)
|
|
expectName, err := endpoint.ReplicationCursorBookmarkName(fs, references.Guid, jobid)
|
|
assert.NoError(ctx, err)
|
|
require.Equal(ctx, expectName, c.GetFilesystemVersion().Name)
|
|
}
|
|
|
|
snap := fsversion(ctx, fs, "@1 with space")
|
|
book := fsversion(ctx, fs, "#1 with space")
|
|
|
|
// create first cursor
|
|
cursorOfSnap, err := endpoint.CreateReplicationCursor(ctx, fs, snap, jobid)
|
|
checkCreateCursor(err, cursorOfSnap, snap)
|
|
// check CreateReplicationCursor is idempotent (for snapshot target)
|
|
cursorOfSnapIdemp, err := endpoint.CreateReplicationCursor(ctx, fs, snap, jobid)
|
|
checkCreateCursor(err, cursorOfSnap, snap)
|
|
// ... for target = non-cursor bookmark
|
|
_, err = endpoint.CreateReplicationCursor(ctx, fs, book, jobid)
|
|
assert.Equal(ctx, zfs.ErrBookmarkCloningNotSupported, err)
|
|
// ... for target = replication cursor bookmark to be created
|
|
cursorOfCursor, err := endpoint.CreateReplicationCursor(ctx, fs, cursorOfSnapIdemp.GetFilesystemVersion(), jobid)
|
|
checkCreateCursor(err, cursorOfCursor, cursorOfCursor.GetFilesystemVersion())
|
|
|
|
destroyed, err := endpoint.DestroyObsoleteReplicationCursors(ctx, fs, &snap, jobid)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
assert.Empty(ctx, destroyed)
|
|
|
|
snapProps, err := zfs.ZFSGetFilesystemVersion(ctx, snap.FullPath(fs))
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
bm, err := endpoint.GetMostRecentReplicationCursorOfJob(ctx, fs, jobid)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
if bm.CreateTXG != snapProps.CreateTXG {
|
|
panic(fmt.Sprintf("createtxgs do not match: %v != %v", bm.CreateTXG, snapProps.CreateTXG))
|
|
}
|
|
if bm.Guid != snapProps.Guid {
|
|
panic(fmt.Sprintf("guids do not match: %v != %v", bm.Guid, snapProps.Guid))
|
|
}
|
|
|
|
// try moving
|
|
cursor1BookmarkName, err := endpoint.ReplicationCursorBookmarkName(fs, snap.Guid, jobid)
|
|
require.NoError(ctx, err)
|
|
|
|
snap2 := fsversion(ctx, fs, "@2 with space")
|
|
|
|
_, err = endpoint.CreateReplicationCursor(ctx, fs, snap, jobid)
|
|
assert.NoError(ctx, err)
|
|
destroyed, err = endpoint.DestroyObsoleteReplicationCursors(ctx, fs, &snap2, jobid)
|
|
|
|
require.NoError(ctx, err)
|
|
require.Equal(ctx, 1, len(destroyed))
|
|
require.Equal(ctx, endpoint.AbstractionReplicationCursorBookmarkV2, destroyed[0].GetType())
|
|
require.Equal(ctx, cursor1BookmarkName, destroyed[0].GetName())
|
|
}
|